Search drivers on NixOS and WSL #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOS usually put drivers under /run/opengl-driver/lib, and WSL mounts drivers under /usr/lib/wsl/lib. Let's also search these paths.
Atry
added a commit
to Atry/nix-ml-ops
that referenced
this pull request
Aug 3, 2024
- This PR removes $CUDA_HOME/lib from $LD_LIBRARY_PATH because bitsandbytes can follow PyTorch's CUDA runtime since bitsandbytes-foundation/bitsandbytes#1041, and setting $LD_LIBRARY_PATH for `bitsandbytes` is not necessary any more - Hard-coded `/run/opengl-driver/lib` are removed because nix-gl-host can print the driver path for both Ubuntu and NixOS since numtide/nix-gl-host#16 - `link-nvidia-drivers.nix` is removed because drivers are instead copied to a cache directory by nix-gl-host
|
I'm a bit confused about the NixOS bit. Why do you need this tool on NixOS exactly, what's your use case? |
|
Unpatched binaries need this tool (along with nix-ld-rs or ld-floxlib) in order to access GPU on NixOS. |
|
Hmm, right, makes sense. That's not a use case I anticipated. |
|
Do you want to merge this PR? |
zimbatm
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NixOS usually links drivers to
/run/opengl-driver/lib, and WSL mounts drivers under/usr/lib/wsl/lib. Let's also search these paths.