MNT: Point mnist data download to ossci server. #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com> Co-authored-by: Melissa Weber Mendonça <melissawm@gmail.com>
|
This pattern raises an interesting edge-case for tutorial infrastructure: how to deal with changes in data sources/data grabbers. Generally speaking, we cache data in tests which means changes related to acquiring data will not be run in CI. This shouldn't be a blocker here, but definitely a case to cover in |
bsipocz
approved these changes
May 20, 2025
|
Thanks @rossbar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #254 using @melissawm and @bsipocz 's idea.
I tried simply swapping out the host URLs from github -> ossci and it seems to work. No idea about rate limits on the bucket but as @bsipocz noted it should at least be better than the status quo.