resolves 6: add support for cmake cxx standard #7
Conversation
prudhomm
commented
Apr 9, 2025
•
prudhomm
commented
- closes add support for CMAKE_CXX_STANDARD #6
- closes add spack environment for proxy-geos #8
use spack env proxy-geos-<execution>
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:18
- [nitpick] Consider renaming the matrix variable 'execution' to a more descriptive term (e.g., 'env_variant' or 'build_mode') to improve clarity on its purpose.
execution: [omp]
.github/workflows/ci.yml:30
- Verify that the dynamically constructed Spack environment name 'proxy-geos-${{ matrix.execution }}' matches an existing environment. If the environment naming convention isn’t consistent, the activation may fail.
spack env activate proxy-geos-${{ matrix.execution }}
There was a problem hiding this comment.
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (4)
- CMakeLists.txt: Language not supported
- CMakePresets.json: Language not supported
- src/sem/CMakeLists.txt: Language not supported
- src/tests/CMakeLists.txt: Language not supported
(for gaya) /cc @prudhomm
…rations add spack rocm environment #9
….com/numpex/proxy-geos-hc into 6-add-support-for-cmake_cxx_standard
| padded_length: 128 | ||
| packages: | ||
| all: | ||
| compiler: [gcc@14:, clang@14:18] |
There was a problem hiding this comment.
Still this warning The packages:all:compiler preference has been deprecated in Spack v1.0, and is currently ignored. It will be removed from config in Spack v1.2.
Oddly, I did not find any fix about this on the doc of spack
There was a problem hiding this comment.
@prudhomm We should add some doc on the step to set the environment up (spack, make, presets, etc...)
|
@prudhomm FYI : on gaya, when I do |
|
Yes i will add the ci for rocm in another one |
