Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for Armitage #5145

Merged
merged 4 commits into from
Jun 28, 2020
Merged

Icons for Armitage #5145

merged 4 commits into from
Jun 28, 2020

Conversation

maxtron95
Copy link
Contributor

Copy link
Member

@palob palob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a spectacular design, thanks for your work. It's a bit detailed (I think for a game icon we can make an exception) and big however. Could we reduce the symbol area by moving the lower hair path 2px up and the avocados? 1px down like this?
Bildschirmfoto vom 2020-03-30 13-28-08
Neck could be shortened by 1px then as well.

Can you please replace color-rendering:auto;color:#000000;dominant-baseline:auto;fill:#02c21c;font-feature-settings:normal;font-variant-alternates:normal;font-variant-caps:normal;font-variant-ligatures:normal;font-variant-numeric:normal;font-variant-position:normal;image-rendering:auto;isolation:auto;mix-blend-mode:normal;paint-order:stroke fill markers;shape-padding:0;shape-rendering:auto;solid-color:#000000;text-decoration-color:#000000;text-decoration-line:none;text-decoration-style:solid;text-indent:0;text-orientation:mixed;text-transform:none;white-space:normal by fill:#02c21c?

@maxtron95
Copy link
Contributor Author

maxtron95 commented Mar 30, 2020

@palob Actually, this is not a game. It is a frontend for Metasploit. (penetration testing)

@palob
Copy link
Member

palob commented Mar 30, 2020

Alright, fancy icon then :)

Copy link
Member

@palob palob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes and sorry for not niticing it earlier: this time we've got a bothering outline. Could you please transform the black path to something like this (made the teeth transparent)?
Bildschirmfoto vom 2020-03-30 13-54-20

Copy link
Member

@palob palob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link
Contributor

@Foggalong Foggalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna reject this one. As @palob says were this a game I'd be tempted to let it through because you've translated it really well, but this is just too detailed for a normal application. I think some variation on the A in the name would work pretty well?

Screenshot from 2020-06-07 18-02-02

@maxtron95
Copy link
Contributor Author

maxtron95 commented Jun 24, 2020

Well that's a shame. However, I redesigned the icon based on the A in the logo.

armitage-ci
armitage-sq

@Foggalong
Copy link
Contributor

@creepertron95 Thanks for reviewing this, the pushed icon is much more Numixy! I've also added a bit to the design guidelines about having too much icon detail; we had mention there of the the "too little detail" case but not the reverse.

@Foggalong Foggalong merged commit a9dbc14 into numixproject:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants