fix(theme): single-click toggle with dark default #223

[AR21SM]

Fixed: Issue on page /intro.html #223

chrome-extension___nlipoenfbbikpbjkfpfillcgkoblgpmj_setup-react.html_from.install.1.mp4

[AR21SM]

Hi @aterrel Could you review this PR?

Best regards,
AR21SM

[melissawm]

I don't want to block valuable contributions (and I think this is one!) but I think we need to consider upstream changes when possible. Relying on custom solutions might work now but break in the future when a new jupyterbook release comes out. In this case, there is an example of discussion around the three-clicks pattern here: pydata/pydata-sphinx-theme#1491

In particular, quoting from that converstion pydata/pydata-sphinx-theme#1491 (reply in thread):

I am unsure if you're thinking about disabling it for you as a user or for some documentation you maintain but having the "auto" option is good from an accessibility point of view for those folks that rely on customisation or accessibility supporting settings.

[AR21SM]

Hi @melissawm,

Thank you for your feedback! I understand the concern about upstream compatibility and the potential risks of custom solutions breaking with future updates.

I reviewed the discussion in pydata/pydata-sphinx-theme#1491, and I see the reasoning behind the three-click pattern and the importance of keeping the "auto" option for accessibility.

Best regards,
AR21SM

[aterrel]

I agree with @melissawm we don't want to just get rid of the auto mode. I do like the MDN Docs example given in the thread. It would allow for other switches.

[AR21SM]

@aterrel Thank you for your valuable feedback!
Should I close this PR for now?
Best regards,
AR21SM