Skip to content

Commit

Permalink
test: Temporarily disable xgboost tests (kubeflow#5093)
Browse files Browse the repository at this point in the history
  • Loading branch information
Jiaxiao Zheng committed Feb 4, 2021
1 parent 85a3b51 commit 513b20b
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 21 deletions.
42 changes: 22 additions & 20 deletions test/component_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,26 +52,28 @@ spec:
value: test/sample-test/Dockerfile
- name: image-name
value: "{{inputs.parameters.target-image-prefix}}{{inputs.parameters.sample-tests-image-suffix}}"
- - name: run-xgboost-tests
template: run-sample-tests
arguments:
parameters:
- name: test-results-gcs-dir
value: "{{inputs.parameters.test-results-gcs-dir}}"
- name: target-image-prefix
value: "{{inputs.parameters.target-image-prefix}}"
- name: gcp-image
value: "{{inputs.parameters.component-image-prefix}}ml-pipeline-gcp:{{inputs.parameters.commit-sha}}"
- name: local-confusionmatrix-image
value: "{{inputs.parameters.component-image-prefix}}ml-pipeline-local-confusion-matrix:{{inputs.parameters.commit-sha}}"
- name: local-roc-image
value: "{{inputs.parameters.component-image-prefix}}ml-pipeline-local-roc:{{inputs.parameters.commit-sha}}"
- name: sample-tests-image
value: "{{inputs.parameters.target-image-prefix}}{{inputs.parameters.sample-tests-image-suffix}}"
- name: namespace
value: "{{inputs.parameters.namespace}}"
- name: test-name
value: "xgboost_training_cm"
# TODO(#5089): Re-enable the xgboost sample test after fixed the
# component and sample.
# - - name: run-xgboost-tests
# template: run-sample-tests
# arguments:
# parameters:
# - name: test-results-gcs-dir
# value: "{{inputs.parameters.test-results-gcs-dir}}"
# - name: target-image-prefix
# value: "{{inputs.parameters.target-image-prefix}}"
# - name: gcp-image
# value: "{{inputs.parameters.component-image-prefix}}ml-pipeline-gcp:{{inputs.parameters.commit-sha}}"
# - name: local-confusionmatrix-image
# value: "{{inputs.parameters.component-image-prefix}}ml-pipeline-local-confusion-matrix:{{inputs.parameters.commit-sha}}"
# - name: local-roc-image
# value: "{{inputs.parameters.component-image-prefix}}ml-pipeline-local-roc:{{inputs.parameters.commit-sha}}"
# - name: sample-tests-image
# value: "{{inputs.parameters.target-image-prefix}}{{inputs.parameters.sample-tests-image-suffix}}"
# - name: namespace
# value: "{{inputs.parameters.namespace}}"
# - name: test-name
# value: "xgboost_training_cm"

# Build and push image
- name: build-image-by-dockerfile
Expand Down
4 changes: 3 additions & 1 deletion test/sample_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ spec:
- name: test-name
value: "{{item}}"
withItems:
- xgboost_training_cm
# TODO(#5089): Re-enable the xgboost sample test after fixed the
# component and sample.
# - xgboost_training_cm
- dataflow
- ai_platform
# TODO(#4361): Re-enable the kubeflow_tf_serving sample test after
Expand Down

0 comments on commit 513b20b

Please sign in to comment.