Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RES-561: Fix pandas deprecation warnings. #310

Merged
merged 1 commit into from
Aug 16, 2017
Merged

RES-561: Fix pandas deprecation warnings. #310

merged 1 commit into from
Aug 16, 2017

Conversation

lscheinkman
Copy link
Contributor

Fixed the following warnings:

  • FutureWarning: pd.ewm_mean is deprecated for Series and will be removed in a future version, replace with Series.ewm(ignore_na=False,min_periods=0,adjust=True,com=50).mean()
  • FutureWarning: pd.ewm_std is deprecated for Series and will be removed in a future version, replace with Series.ewm(ignore_na=False,min_periods=0,adjust=True,com=50).std(bias=False)
  • FutureWarning: iget(i) is deprecated. Please use .iloc[i] or .iat[i]

@rhyolight @subutai Please review

@lscheinkman lscheinkman requested a review from scottpurdy August 16, 2017 19:22
scottpurdy
scottpurdy approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@scottpurdy scottpurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine to me - were you able to validate that the results don't change?

@lscheinkman
Copy link
Contributor Author

Yes, same results

@lscheinkman lscheinkman merged commit 4e45930 into numenta:master Aug 16, 2017
@lscheinkman lscheinkman deleted the RES-561 branch August 16, 2017 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottpurdy scottpurdy scottpurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lscheinkman @scottpurdy