[Issue] 在送 poscapture 時的 message 會自動帶入原先的 caption ike

[sync-by-unito]

Description

當拍完照使用 caption 後再轉送 不會自動帶入 若在轉送 poscapture 沒有填 message 原先填的 caption 會消失

Steps to Reproduce

1. tack a picture
2. wait it upload finish
3. click the capture into detile page
4. click the caption key in some word
5. click the "..."
6. choose " transfer ownership "
7. select contact
8. message keep null
9. send out
10. receiv the postcapture
11. the caption become blank Not the text entered in step 4

Expected Behavior

• Expected: caption 自動帶入在送 poscapture 時的 message

Actual Behavior

• Actual: poscapture 時的 message 會覆蓋原先的 caption

Environment

• Version: 0.45.1
• OS: all OS
• Device: all device

┆Issue is synchronized with this Asana task by Unito
┆Created By: Scott Yan

[sync-by-unito]

➤ James Chien commented:

Likely to be a backend issue. I'll confirm it after doing some test on backend.

[sync-by-unito]

➤ Ray Hung commented:

Might also be a frontend issue

capture-lite/src/app/features/home/sending-post-capture/sending-post-capture.page.html

Lines 20 to 23 in 0797302

	<mat-label>{{ t('.message') }}</mat-label>
	<textarea
	[(ngModel)]="previewCaption"
	name="caption"

(

capture-lite/src/app/features/home/sending-post-capture/sending-post-capture.page.html

Lines 20 to 23 in 0797302

	<mat-label>{{ t('.message') }}</mat-label>
	<textarea
	[(ngModel)]="previewCaption"
	name="caption"

)

capture-lite/src/app/features/home/sending-post-capture/sending-post-capture.page.ts

Lines 155 to 165 in fc8f018

	async send(captionText: string) {
	const action$ = combineLatest([this.asset$, this.receiverEmail$]).pipe(
	first(),
	switchTap(([asset, contact]) =>
	this.diaBackendTransactionRepository.add$({
	assetId: asset.id,
	targetEmail: contact,
	caption: captionText,
	createContact: this.shouldCreateContact,
	})
	),

(

capture-lite/src/app/features/home/sending-post-capture/sending-post-capture.page.ts

Lines 155 to 165 in fc8f018

	async send(captionText: string) {
	const action$ = combineLatest([this.asset$, this.receiverEmail$]).pipe(
	first(),
	switchTap(([asset, contact]) =>
	this.diaBackendTransactionRepository.add$({
	assetId: asset.id,
	targetEmail: contact,
	caption: captionText,
	createContact: this.shouldCreateContact,
	})
	),

)

Seems like we're passing the "message" user enter when sending Capture as caption, not the real caption of the Capture.

[sync-by-unito]

➤ Ray Hung commented:

James Chien
When sending Capture/creating transaction using api/v3/transactions/ ( https://api.numbersprotocol.io/api/v3/transactions/ ), should the caption be the caption of the Capture? Or it should be the message user enter when sending Capture? I assume it's the former one not the later one?

[sync-by-unito]

➤ James Chien commented:

The latter one, and the caption ovewrite behaviour is intended. The problem here is the caption should not be overwritten when user didn't enter anything. (Backend should not overwritten the caption when no caption is provided in request body, and make sure app don't pass empty value to caption field)

[sync-by-unito]

➤ Ray Hung commented:

James Chien I add a check on frontend to pass in message as caption if message is not empty. Otherwise I pass in the original caption. This way we don't have to change backend. Demo video here: https://www.youtube.com/watch?v=upv_nFtirGc ( https://www.youtube.com/watch?v=upv_nFtirGc ), https://youtu.be/0o___Lf9KXQ ( https://youtu.be/0o___Lf9KXQ )
What do you think?

[sync-by-unito]

➤ James Chien commented:

Seems works perfectly. I just checked the backend code and it seems it's already not overwriting the caption when caption is not provided.

[sync-by-unito]

➤ Ray Hung commented:

PR opened here: #1287 ( #1287 )