Skip to content

Conversation

@b07902011
Copy link
Contributor

@b07902011 b07902011 commented Jan 19, 2022

…op update

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have build workflow which is triggered upon every push and pull request. Maybe by adding a slack notification stage to the last part we wouldn't be needing another separated workflow?

Might be able to use something like if: github.ref == 'refs/heads/develop' in the slack job stage

Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@b07902011 b07902011 merged commit 38460af into develop Jan 24, 2022
@shc261392 shc261392 deleted the feature-slack-notification branch January 24, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants