Check Capture Wallet page and summarize if there is anything need to be updated due to this migration

[sync-by-unito]

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

[sync-by-unito]

➤ Sam commented:

Bofu Chen,
Currently, On the wallets page, we first call

1. getAssetWallets() ( https://github.com/numbersprotocol/capture-lite/blob/38a2d4debfe6c9beb6888f2703b86cd72986f455/src/app/shared/dia-backend/wallet/dia-backend-wallet.service.ts#L74 ) returns { "num_balance": { "bsc_num": "string", "eth_num": "string"} },
2. in between we also call this endpoint ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/auth_users_me_read ) which returns => { "user_wallet": {"points": "string"}},
3. then we calculate ( https://github.com/numbersprotocol/capture-lite/blob/38a2d4debfe6c9beb6888f2703b86cd72986f455/src/app/features/wallets/wallets.page.ts#L136 ) the total balance by adding num_balance.bsc_num + user_wallet.points

I'm not sure why we do not do num_balance.bsc_num + num_balance.eth_num + user_wallet.points to calculate the total balance?

When we do the migration getAssetWallets() will return { "num_balance": { "bsc_num": "string", "eth_num": "string"}, "num": "string|number"}
Then I assume that to calculate the total balance we would probably do:

• • num_balance.bsc_num
• • num_balance.eth_num (optional?)
• • num_balance.num
• = total balance

Tammy Yang, if my understanding is correct then YES we need to update the wallets page.

Please let me know if I got something wrong or missing.

[sync-by-unito]

➤ Bofu Chen commented:

Sam

1. Capture App does not support using ERC20 NUM (Ethereum) to pay because the Tx is slower and the cost is higher (compared to BEP20 NUM & native NUM)
2. It's sufficient currently to add native NUM into the balance calculation.

To ensure that Capture App can work even if the backend support is not ready, remember to add error handling when retrieving the balances of ERC20/BEP20/native NUM and Capture Credit.

Please add this support to the release tomorrow. Many thanks!

[sync-by-unito]

➤ Bofu Chen commented:

Sam Current Figma does not define the wording for native NUM. Please double-check with Noir after they come back from the holiday season.

I think "mainnet" might be more understandable than "native" for the users.

Tammy Yang I will let Sam go first with the discussion above.

[sync-by-unito]

➤ Bofu Chen commented:

Current Figma (no dollar sign in the sub-area)

[sync-by-unito]

➤ Sam commented:

Bofu Chen, then for now the design will be something like
MAINNET: 200 ERC20: 6,3000 BEP20: 6,300 Stacked: 1,200

[sync-by-unito]

➤ Bofu Chen commented:

Hide ERC20 & Staked because Capture App does not support them currently

[sync-by-unito]

➤ Sam commented:

Bofu Chen, just a status update, had a huddle with Tammy Yang.
and this is related miro ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764542087213526&cot=14 ).

Actions items for this task to be considered as done are:

1. Keep the current design (it won't fit Figma)
2. Replace BEP20 to Mainnet (BEP20 will disappear)
3. Update explorer URL and text
4. Force update

[sync-by-unito]

➤ Sam commented:

Kenny Hung, regrading 4. Force update, just want to remind you that when we publish this change to the App/Play stores we also need to set ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#tag/services )update_urgency to critical so users will be forced to update the app.

[sync-by-unito]

➤ Sam commented:

Kenny Hung, is this ok?

Previously we had
"viewOnBscScan": "View on BscScan",
"viewOnBscScan": "在 BscScan 上查看",

Now I will change it to Mainnet NUM
"viewOnMainnetScan": "View on NUM Mainnet",
"viewOnMainnetScan": "在 NUM Mainnet 上查看",

Please let me know if any changes are needed.

[sync-by-unito]

➤ Kenny Hung commented:

Sofia Yan (cc Tammy Yang) ^^ Please help to confirm this one. Thanks.

[sync-by-unito]

➤ Sam commented:

Sofia Yan, there was one more translation so maybe we can manage wallet migration translation at wallet page translations related migration ( https://app.asana.com/0/0/1203616763834799 ).

[sync-by-unito]

➤ Sam commented:

Bofu Chen, currently we can see ( https://github.com/numbersprotocol/capture-lite/blob/7023e3df653d46bc1f5442babb9b593dbadb7a59/src/app/features/wallets/wallets.page.ts#L102 ) wallet history using bscscan.com ( https://bscscan.com ). If I want to show wallet history in mainnet.num.network ( https://mainnet.num.network/overview ) ( https://mainnet.num.network/overview )which params I should pass?

[sync-by-unito]

➤ Bofu Chen commented:

Sam Change this.domainBscScan to mainnet.num.network should work (EIP-3091, https://eips.ethereum.org/EIPS/eip-3091 ( https://eips.ethereum.org/EIPS/eip-3091 )).

If you find that it does not work, please let me know and I will ask Ethernal to fix it.

[sync-by-unito]

➤ Bofu Chen commented:

Sam Because native NUM is not ERC20 token, you can use

https://mainnet.num.network/address/0x51130db91b91377a24d6ebeb2a5fc02748b53ce1 ( https://mainnet.num.network/address/0x51130db91b91377a24d6ebeb2a5fc02748b53ce1 )

to show the wallet history

[sync-by-unito]

➤ Sam commented:

Bofu Chen thank you. I will do that tomorrow morning.