Show custody wallet balance instead of Capture wallet balance

[sync-by-unito]

As a user, I want to see my custody wallet balance instead of Capture wallet if my main wallet is the custody wallet.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

[sync-by-unito]

➤ Ray Hung commented:

Depend on backend release

[sync-by-unito]

➤ Ray Hung commented:

James Chien
What's difference between asset wallet and managed wallet?
Seems like getManagedWallet$ ( https://github.com/numbersprotocol/capture-lite/blob/3ac96f0f5d1068de52c34a33162d2a8f61811022/src/app/shared/dia-backend/wallet/dia-backend-wallet.service.ts#L59-L68 ) is not being used anywhere? Search here ( https://github.com/numbersprotocol/capture-lite/search?q=getManagedWallet%24 ).

[sync-by-unito]

➤ Ray Hung commented:

To show custody wallet balance instead of Capture wallet balance, I may need to update the api endpoint url here ( https://github.com/numbersprotocol/capture-lite/blob/3ac96f0f5d1068de52c34a33162d2a8f61811022/src/app/shared/dia-backend/wallet/dia-backend-wallet.service.ts#L38 ) right?

[sync-by-unito]

➤ James Chien commented:

Ray Hung
Asset wallet

• Also called Capture wallet
• Every user has exactly 1 this type of wallet
• Used for signing Capture proof
• Both the user and the backend have access to its private key
• Currently used for paying with NUM or receiving NUM as payment as CaptureClub creator

Managed wallet

• Also called custody/custodial wallet
• Every user has exactly 1 this type of wallet
• All NFTs and minted and transferred between this wallet
• User does not have access to the private key, only we do
• Will become the wallet for paying/receiving NUM

The current problem is App retrieves asset wallet's NUM balance, but after backend migrates the NUM payment to managed wallet, App should get managed wallet's NUM balance instead.

Here's what I have in mind. Since we will not perform the NUM wallet migration at backend immediately, it's best that App doesn't need to know about the migration at all. I'll add an endpoint /wallets/num-wallet/ for App to use. Change the data source for displaying NUM balance to this endpoint and that should be all.

[sync-by-unito]

➤ Ray Hung commented:

Update: /wallets/num-wallet/ ( https://dia-backend-dev.numbersprotocol.io/api/v3/redoc/#operation/wallets_num_wallet ) is working. Frontend app is getting data from the endpoint.

[sync-by-unito]

➤ Ray Hung commented:

James Chien I saw that Backend (Seal API)-Storage-backend rc13.1-0.33.1-postman has passed QA testing. Let me know when I should go ahead and submit a PR for frontend app changes to call the new api/v3/wallets/num-wallet/ endpoint

[sync-by-unito]

➤ Ray Hung commented:

Just opened one here: #1269 ( #1269 )

[sync-by-unito]

➤ Ray Hung commented:

James Chien Another question, since now we will be displaying balance from managed wallet, should we update wallet address to managed wallet address? Now we're still displaying asset wallet address

[sync-by-unito]

➤ James Chien commented:

Asset wallet's primary purpose is for signing Capture proofs and we'd like the users to own this wallet, so we wouldn't want to replace it no matter NUM balance comes from it or not.
For displaying custody wallet's address, there's a task for it Show NUM balance from custody wallet and allow users to see custody-wallet transaction history ( https://app.asana.com/0/1201016280880500/1201812866141486/f )

[sync-by-unito]

➤ Ray Hung commented:

I see. Not sure if all users are aware that there are two wallets (asset/managed). Do you think we can update "Wallet Address" to "Asset Wallet Address" or "Capture Wallet Address" to be more explicit?

[sync-by-unito]

➤ James Chien commented:

A good point, but I'm not sure what is the text we want to show to users

Tammy Yang Ray has some UI suggestions^^

[sync-by-unito]

➤ Ray Hung commented:

Update: feat(dia-backend-wallet.service.ts): show custody wallet balance #1269 ( #1269 ) has been merged

[sync-by-unito]

➤ Ray Hung commented:

Tammy YangDaYuan
Some UI ideas:

• From the discussion above, rename "Wallet Address" to "Asset Wallet Address" or "Capture Wallet Address" to be more explicit?

• We might want to have wallet relevant functionalities in its own page. Like having a "Wallet" tab under profile in the upper left side navigation.

  • Why? Since Capture App is going to support

    • Viewing Transaction history
    • Moving NUM in between asset and managed wallet
    • Buying NUM with credit card
    • And maybe more to come in the future.

  • I think wallet deserves its own page so that we have cleaner UI in both the profile page and wallet page.

  • This way maybe we can also show asset wallet NUM balance so users don't have to check it on EtherScan/BscScan themselves

• One more idea, are most of the users familiar with the idea that they have 2 wallets (asset & managed), and the difference between them? (I don't think so?) Maybe we want to make it clear which balance/address is for which and somehow educate users about asset wallet v.s. managed wallet.

[sync-by-unito]

➤ Tammy Yang commented:

Ray Hung good idea

I think in the future, we can call custody wallet “asset wallet” and Capture wallet “integrity signature key” or “integrity key” or “signature” because we will only use it for “signature” instead of using it as a wallet.

Bofu Chen what's your suggestion of the name of the future capture wallet?