Improve gitlab2rbac by leveraging GraphQL and adding a few configuration variable #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… queries made on the Gitlab API
ramnes
approved these changes
Aug 10, 2024
ribetm
reviewed
Aug 14, 2024
Co-authored-by: Mathis Ribet <mathis.ribet@2021.icam.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to leverage GraphQL queries instead of doing as many queries as there's member in namespaces
I've also took the liberty to implement a GITLAB_GROUPS_IGNORE_LIST to ignore
the lost-and-foundgroup by defaultAnd add USERNAME_IGNORE_LIST to ignore users such as "root" or any special users you don't want to give access to Kubernetes