fix: get pl kind apiversion #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
whynowy
reviewed
Oct 4, 2023
pkg/client/clientset/versioned/typed/numaflow/v1alpha1/pipeline.go
Outdated
Show resolved
Hide resolved
whynowy
reviewed
Oct 4, 2023
pkg/client/clientset/versioned/typed/numaflow/v1alpha1/pipeline.go
Outdated
Show resolved
Hide resolved
added 5 commits
October 4, 2023 12:11
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
whynowy
reviewed
Oct 4, 2023
whynowy
reviewed
Oct 4, 2023
There was a problem hiding this comment.
Revert the change on this file, or the ci will not pass.
added 2 commits
October 4, 2023 12:22
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
whynowy
approved these changes
Oct 4, 2023
darshansimha
pushed a commit
to darshansimha/numaflow
that referenced
this pull request
Oct 5, 2023
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
bbehnke
added a commit
that referenced
this pull request
Oct 17, 2023
fix: sorting issue fix and arrow icon for navigating to namespace (#1157) Signed-off-by: Darshan Simha <darshan_simha@intuit.com> Co-authored-by: Darshan Simha <darshan_simha@intuit.com> feat: isb update implemented and search input styling (#1158) Signed-off-by: bbehnke <bradleybehnke@yahoo.com> fix: get pl kind apiversion (#1159) Signed-off-by: jyu6 <juanlu_yu@intuit.com> feat: all spec crud (#1163) Signed-off-by: bbehnke <bradleybehnke@yahoo.com> Pause resume for pipelines (#1167) Co-authored-by: Darshan Simha <darshan_simha@intuit.com> feat: crud updates and error/loading handling (#1183) Signed-off-by: bbehnke <bradleybehnke@yahoo.com> fix: fixed the timing issue on resume and pause (#1185) Co-authored-by: Darshan Simha <darshan_simha@intuit.com> feat: error handling/display for all pages and pipeline load block (#1187) fix: overridden changes re-merge (#1194) Signed-off-by: Darshan Simha <darshan_simha@intuit.com> Co-authored-by: Darshan Simha <darshan_simha@intuit.com> fix: fixed the timing issue on resume and pause (#1197) Signed-off-by: Darshan Simha <darshan_simha@intuit.com> Co-authored-by: Darshan Simha <darshan_simha@intuit.com> fix: vertex update tweaks and general text/alignment fixes (#1200) fix: set size on sidebar slide icon (#1201) Signed-off-by: bbehnke <bradleybehnke@yahoo.com>
bbehnke
added a commit
that referenced
this pull request
Oct 17, 2023
fix: sorting issue fix and arrow icon for navigating to namespace (#1157) Signed-off-by: Darshan Simha <darshan_simha@intuit.com> Co-authored-by: Darshan Simha <darshan_simha@intuit.com> feat: isb update implemented and search input styling (#1158) Signed-off-by: bbehnke <bradleybehnke@yahoo.com> fix: get pl kind apiversion (#1159) Signed-off-by: jyu6 <juanlu_yu@intuit.com> feat: all spec crud (#1163) Signed-off-by: bbehnke <bradleybehnke@yahoo.com> Pause resume for pipelines (#1167) Co-authored-by: Darshan Simha <darshan_simha@intuit.com> feat: crud updates and error/loading handling (#1183) Signed-off-by: bbehnke <bradleybehnke@yahoo.com> fix: fixed the timing issue on resume and pause (#1185) Co-authored-by: Darshan Simha <darshan_simha@intuit.com> feat: error handling/display for all pages and pipeline load block (#1187) fix: overridden changes re-merge (#1194) Signed-off-by: Darshan Simha <darshan_simha@intuit.com> Co-authored-by: Darshan Simha <darshan_simha@intuit.com> fix: fixed the timing issue on resume and pause (#1197) Signed-off-by: Darshan Simha <darshan_simha@intuit.com> Co-authored-by: Darshan Simha <darshan_simha@intuit.com> fix: vertex update tweaks and general text/alignment fixes (#1200) fix: set size on sidebar slide icon (#1201) Signed-off-by: bbehnke <bradleybehnke@yahoo.com> Signed-off-by: bbehnke1 <bradley_behnke@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because of kubernetes/kubernetes#80609
get pipeline doesn't return "kind" and "apiVersion"
since we know the value for these two fields, set the fields in handler manually
test result:
