Skip to content

Conversation

@numToStr
Copy link
Owner

This adds error handling to the plugin, implemented with the help of assert and xpcall. Adding explicit error handling for the following cases:

  • Invalid commenstring / Commenting is not supported like json
  • When filetype doesn't support block comments like yaml
  • Graceful handling of certain cases like uncommenting when there is nothing to uncomment.

fixes #221
supersedes #277

@numToStr numToStr changed the title fix!: error handling chore!: error handling Dec 24, 2022
@numToStr numToStr marked this pull request as ready for review December 24, 2022 09:11
@numToStr numToStr merged commit 2a16514 into master Dec 24, 2022
@numToStr numToStr deleted the error branch December 24, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] api.uncomment.linewise.* give error when nothing to uncomment

2 participants