Skip to content

Conversation

@jgollenz
Copy link
Contributor

In case you never heard of it: Nushell

@jgollenz
Copy link
Contributor Author

@numToStr do you have any criteria for adding languages to this plugin? I see some missing from the list, but you might consider them not popular enough.

@numToStr
Copy link
Owner

do you have any criteria for adding languages to this plugin?

I generally look for if vim has native syntax highlighting, a famous community plugin for highlights, or a tree-sitter parser. If the filetype has any of those then it's good to go.

I know about nushell though, but being a new shell I don't know if there is any highlighting support as of now.

@jgollenz
Copy link
Contributor Author

Thanks for clarifying 👍
As far as nushell is concerned, I wouldn't say famous, but a plugin (plus grammar) exists.

@numToStr
Copy link
Owner

(plus grammar)

That's good to know. Can it be installed via TSInstall? Or does it require some config?

@numToStr numToStr self-requested a review August 21, 2022 08:10
@jgollenz
Copy link
Contributor Author

jgollenz commented Aug 21, 2022

Unfortunately it is not yet part of the grammars available through the nvim-treesitter repo. However, the nvim-nu plugin takes care of that in the background. Once the plugin is installed, TSInstall nu will download and setup the nu grammar.

edit:

does it require some config

so yes, additional config (installing the plugin + calling TSInstall nu afterwards) is required.

@numToStr
Copy link
Owner

Understood. And looking at the parser repo, i believe it's broken for newer nushell version. Well I hope someday it'd get fixed and upstreamed to nvim-treesitter :)

@numToStr numToStr merged commit ba5903b into numToStr:master Aug 21, 2022
@jgollenz
Copy link
Contributor Author

jgollenz commented Aug 21, 2022

it's broken for newer nushell version

Unfortunately, yes :( I understand if you want to wait with this PR until it is up-to-date.

edit: but to be fair, it appears to be "mostly" working for me, even on newer nushell versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants