Add replace_keycodes=false to expr mappings
#190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neovim/neovim#19598 changed vim.keymap.set to replace keycodes by default for all mappings if expr == true instead of only luaref expr mappings. The toggle expr mappings are not luarefs but shouldn't have the keycodes replaced since they use <Plug>.
Owner
|
Is this backwards compatible? |
|
Should be since it's just specifying the old default. I just tested this PR both with and without that commit and it works fine in either case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
neovim/neovim#19598 changed
vim.keymap.setto replace keycodes by default for all mappings ifexpr == trueinstead of only luaref expr mappings.The toggle expr mappings are not luarefs but shouldn't have the keycodes replaced since they use
<Plug>.