Skip to content

Conversation

@numToStr
Copy link
Owner

@numToStr numToStr commented Jul 12, 2022

Added

  • utils.commenter()
  • utils.uncommenter()

Changed

  • utils.{unwrap_cstr,parse_cstr}() now returns string, string instead of string|bool, string|bool
  • Merged Op.blockwise_x() with Op.blockwise()
  • Removed utils.get_padding(), utils.move_n_insert() and utils.grab_indent()
  • Removed utils.comment_str() (Use utils.commenter())
  • Removed utils.uncomment_str() (Use utils.uncommenter())
  • Changed utils.is_commented() function signature.

This will break your setup if you are depending on the internal functions. So feel free ask anything regarding the above changes.

Resolve #177

@numToStr numToStr changed the title chore: refactor out the old stuff chore: refactoring and emmylua Jul 12, 2022
@numToStr numToStr changed the title chore: refactoring and emmylua chore!: refactoring Jul 17, 2022
@numToStr numToStr marked this pull request as ready for review July 17, 2022 14:56
@numToStr numToStr merged commit 761f63f into master Jul 17, 2022
@numToStr numToStr deleted the refactor branch July 17, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It's time for refactoring

2 participants