This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
fix: Add User-Agent header to fix CDN blockage #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: |
makisukurisu
commented
Apr 28, 2024
Comment on lines
+4
to
+5
| "source.fixAll": "explicit", | ||
| "source.organizeImports": "explicit" |
There was a problem hiding this comment.
Visual Studio Code did this by itself:
makisukurisu
commented
Apr 28, 2024
Comment on lines
+42
to
+43
| headers: {'User-Agent': 'Boorusphere/1.4.3'}, | ||
| ); |
There was a problem hiding this comment.
The main change
makisukurisu
commented
Apr 28, 2024
There was a problem hiding this comment.
Some packages were updated automatically
makisukurisu
commented
Apr 28, 2024
| file_picker: ^5.2.3 | ||
| flutter_cache_manager: ^3.0.0-nullsafety.1 | ||
| flutter_displaymode: ^0.6.0 | ||
| flutter_downloader: ^1.9.0 | ||
| flutter_downloader: ^1.10.4 |
There was a problem hiding this comment.
Bumped this requirement because app build was getting crazy. Perhaps it's not required.
But I got an error saying that Enumerator was somehow invalid.
makisukurisu
commented
Apr 28, 2024
| @@ -81,6 +80,7 @@ dependencies: | |||
| wakelock: ^0.6.2 | |||
| xml2json: ^6.0.0 | |||
| yaml: ^3.1.0 | |||
| extended_image: ^8.2.0 | |||
There was a problem hiding this comment.
Same here, I've got build errors for no fault of mine, reinstalling this dependency resolved the issue.
|
Thank you so much 😭 |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #150, by replacing a default User-Agent header from
FlutterDownloaderto a custom one.This effect can also be achieved, as described in #150, by simply removing this header altogether, however I have not tried to do this.
I can provide a screenshot of the app interface with working downloads, as well as console output:
Feel free to change the user agent, discard other alterations, or just ditch this change in favor of some other edit.