fix(ci): replace gh pr review with gh api for checkout-free approval#433
Merged
Conversation
gh pr review implicitly requires a local git repository, causing "fatal: not a git repository" in ci-gated-approve which runs without checkout. This broke OpenSSF Scorecard Code-Review scoring by preventing Justice Bot from recording approvals on PRs. Both approve steps (dependency-review and ci-gated-approve) now use gh api directly, consistent with the existing duplicate-check pattern and the no-checkout security stance. Signed-off-by: Null;Variant <null@nullvariant.com> 🖥️ IDE: [VS Code](https://code.visualstudio.com/) 🔌 Extension: [Claude Code](https://claude.ai/download) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Model-Raw: claude-opus-4-6-20250414
Review Summary by QodoReplace gh pr review with gh api for checkout-free approvals
WalkthroughsDescription• Replace gh pr review with gh api for checkout-free PR approvals • Fixes Justice Bot approval failures in ci-gated-approve job • Restores OpenSSF Scorecard Code-Review scoring capability • Maintains consistency with existing duplicate-check pattern Diagramflowchart LR
A["gh pr review<br/>requires git repo"] -->|broken in<br/>no-checkout job| B["ci-gated-approve fails"]
B -->|breaks| C["OpenSSF Scorecard<br/>Code-Review score"]
D["gh api direct call<br/>no git required"] -->|fixes| E["ci-gated-approve succeeds"]
E -->|restores| F["OpenSSF Scorecard<br/>Code-Review score"]
File Changes1. .github/workflows/justice-bot.yml
|
Code Review by Qodo
1. Repeated bot approvals
|
Contributor
🐰 Mimi's Validation Report ✅All checks are looking good! Great job! 🎉 ⏳ Some checks are still running. I will keep watching!
This report was carefully prepared by nullvariant-mimi[bot] |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
🕊️ Ciel's Mediation 💤*~~ drifting lazily through still air ~~ The zoo is napping today...* 1 zoo member has reviewed this PR.
😴 A quiet day at the zoo. Only one member peeked at this PR.
This mediation was peacefully delivered by nullvariant-ciel[bot] |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh pr reviewimplicitly requires a local git repository, causingfatal: not a git repositoryin theci-gated-approvejob which intentionally runs withoutactions/checkoutdependency-reviewandci-gated-approve) now usegh apidirectly, consistent with the existing duplicate-check pattern and the no-checkout security designTest plan
ci-gated-approvejob succeeds on the next PRnullvariant-justice[bot]