Chat Relay#5
Conversation
|
also gimme kvm role pls :) |
112batman
left a comment
112batman
left a comment
There was a problem hiding this comment.
A couple small things other then that it looks fine to me, haven't actually tested the bot yet.
|
it is indeed drippy, but please dont put it in title |
Added comments for easier understanding
112batman
left a comment
112batman
left a comment
There was a problem hiding this comment.
Please check other files for the casing, I might've missed some.
112batman
left a comment
112batman
left a comment
There was a problem hiding this comment.
I think you said you were already gonna do this, but please use jimp (or another library) to extract the heads of players (and cache them) based on the skin data from Mojangs CDN, instead of using the mc-heads api.
|
we could also use https://wiki.vg/Protocol#Player_Info for the heads, which would be b64 so no Caching needed (correct me if im wrong) |
|
I fixed some of your problems in my last pull request to @ATXLtheAxolotl fork. The Minecraft heads thing is the only issue remaining |
112batman
left a comment
112batman
left a comment
There was a problem hiding this comment.
Nothing very significant, but this is what opinionated me thinks should be done differently.
|
@nullsoepic When this eventually gets merged please squash so you don't add like 25 commits to the main branch. |
fix(): Attempt to connect every minute instead of three seconds feat(): Allow people to ping indivual users
preference(): Change image background color to be close to embed
112batman
left a comment
112batman
left a comment
There was a problem hiding this comment.
Update the comment with the new delay and you can merge it
4 participants
This PR will resolve #3
Will Require:
There appears to be an issue that causes it sometimes to not parse a packet. I'm presuming it is a chat packet that has an unknown which will need to be investigated by minecraft-data contributors but otherwise it is functional
Also the /status command is super super long, we should probably find a better way of listing players, other then covering the entire screen in the future.