use screen line instead of logical line #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for the PR! This is close, but still doesn't quite behave properly. Create a file like this: Then |
Contributor
Author
|
it works fine for me: 20250128-122216-485171530.mp4maybe the behavior you saw is related to 20250128-122648-470074110.mp4if this is the case, maybe we should put: at function start and put: at function end |
Owner
|
I do not use smoothscroll. Here is how it looks for me on the current Screen.Recording.2025-01-28.140921.mp4And here is how it look with the changes in this PR: Screen.Recording.2025-01-28.141750.online-video-cutter.com.mp4HOWEVER, notice that after I zoom in, the problem goes away. So I'm not 100% sure how to trigger this, but somehow through resizing my terminal window, splitting inside vim, zooming in and out, etc. I am able to consistently (but not repeatably) encounter this behavior where it snaps line 17 to the top. Apologies, I don't know how to record with the keystrokes. Any tips on this would be appreciated. Furthermore, it your cursor is in the middle of line 12, centering will move the cursor to line 11, which is not desirable. This behavior exists in both versions, so maybe it can be a separate bug. |
Contributor
Author
|
I didn't express myself clearly. What I meant is that you need to The software displaying my key presses is Screenkey.
As for the this issue, it seems to be caused by |
Closed
Owner
|
Ah, I see now. Yes, you are right. I was able to replicate the weird buggy behavior, then toggle smoothscroll on and off and it always worked correctly with smoothscroll on and incorrectly with smoothscroll off. I will add a smoothscroll setting in another commit (see #17) and accept this PR. I also created a separate issue for the line changing thing (#18). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use screen line instead of logical line to calculate offset
may fix #13 #14