fix(external-dns): change policy to variable #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violenti
approved these changes
Nov 26, 2025
sebastiancorrea81
added a commit
that referenced
this pull request
Jan 26, 2026
🤖 I have created a release *beep* *boop* --- ## [1.23.0](v1.22.1...v1.23.0) (2026-01-26) ### Features * add action of release ([cbee19a](cbee19a)) * add action of release ([8f695ed](8f695ed)) * add action of release ([9421b67](9421b67)) * add agent, scope and scope association ([f508cca](f508cca)) * add agnostic agent ([1d1d5e3](1d1d5e3)) * add aks module ([ef313d9](ef313d9)) * add data tenent id ([993dd15](993dd15)) * add image_tag var ([87b8758](87b8758)) * add output vnet ([d20b871](d20b871)) * add scope definion agent association ([416526d](416526d)) * add scope definition modules ([eba0ba3](eba0ba3)) * add sku input ([01450ac](01450ac)) * add sku input ([78107a9](78107a9)) * add sku input ([faa4700](faa4700)) * add support for aro ingress controller ([6fe2813](6fe2813)) * add support to prometheus operator ([5e85aa1](5e85aa1)) * add validatation cloud provider ([f1880ad](f1880ad)) * **aent:** add init_scripts ([4b91906](4b91906)) * **aent:** add init_scripts ([e806f3f](e806f3f)) * **aent:** delete unknow args ([8f3bffc](8f3bffc)) * **agent:** add azure config to agent ([c27d6a5](c27d6a5)) * **agent:** add azure to agent ([0bde56c](0bde56c)) * **agent:** add config external-dns to aws config ([3d69436](3d69436)) * **agent:** add config external-dns to aws config ([#105](#105)) ([1a828f9](1a828f9)) * **agent:** add config for azure ([23da9fd](23da9fd)) * **agent:** add multi cloud ([adbaa97](adbaa97)) * **agent:** fix cert-manager name templates ([a3913db](a3913db)) * **agent:** fix image tag variable ([667da65](667da65)) * **agent:** fix readme ([96faf72](96faf72)) * **agent:** fix template default ([dc225b5](dc225b5)) * **agent:** fix template default ([9ac324c](9ac324c)) * **agent:** move identical variables to global configuration ([2b78254](2b78254)) * **agent:** move image-tag variable ([f9ac77b](f9ac77b)) * **agent:** move image-tag variable ([8c0c483](8c0c483)) * **agent:** reactor cert-manager ([36026dd](36026dd)) * **agent:** tofu fmt ([e5aa787](e5aa787)) * aks acr integration ([#120](#120)) ([e2237b6](e2237b6)) * aks module release ([51ff70d](51ff70d)) * **aro:** added google and cloudflare ns for txt record validation ([6714185](6714185)) * **auth:** add output authorization module ([b3f616c](b3f616c)) * **aws-iam:** add aws iam module ([8f53196](8f53196)) * **aws-iam:** add aws iam module ([f728ef3](f728ef3)) * **aws-iam:** add output to rol arn ([ac7676d](ac7676d)) * **aws:** fix cloud aws domain_name ([60eabd3](60eabd3)) * **azure:** Add private DNS zone module ([813cad3](813cad3)) * **azure:** Add private DNS zone module ([#90](#90)) ([5d4399e](5d4399e)) * **cert manager:** add support namespace name for cert manager ([d44f7c7](d44f7c7)) * **cert-manager:** add aws support ([858e346](858e346)) * **cert-manager:** fix version helm cert manage ([79796a8](79796a8)) * **cert-manager:** normalize naming to helm ([b8e9e7b](b8e9e7b)) * **cert-manager:** separate providier ([9e8bc7b](9e8bc7b)) * **cert-manager:** separate providier ([0888dbe](0888dbe)) * **cert-manager:** separate providier ([cd7e81e](cd7e81e)) * **cert-manager:** separate providier ([f39fa84](f39fa84)) * **cert-manager:** separate providier ([a2dfadb](a2dfadb)) * **cert-manager:** separate providier ([882933b](882933b)) * **cert-manager:** separate providier ([3bd79db](3bd79db)) * **cert-manager:** separate providier ([b51fec9](b51fec9)) * **cert-manager:** update varsion cert manager ([46b388e](46b388e)) * **chart:** new version of charts ([#122](#122)) ([83a8b39](83a8b39)) * edit acr georeplication ([1448c56](1448c56)) * edit count of nodes ([bd46b4c](bd46b4c)) * edit node agents_pool_max_surge ([bca13bd](bca13bd)) * edit node agents_pool_max_surge ([3a5bec1](3a5bec1)) * edit provider aks ([c6817f2](c6817f2)) * edit readme ([#63](#63)) ([12cb339](12cb339)) * edit var ([b4e869f](b4e869f)) * edit var ([57da603](57da603)) * edit variables ([44c9674](44c9674)) * edit variables ([60f47ed](60f47ed)) * edit variables ([cc370e5](cc370e5)) * edit variables ([3002fcc](3002fcc)) * edit variables ([99cf67a](99cf67a)) * **esternal-dns:** resolve conflicts ([4f71b63](4f71b63)) * **external-dns:** add config to aws ([0b492b8](0b492b8)) * **external-dns:** add validation to variables ([c4c3e36](c4c3e36)) * **external-dns:** add validation to variables ([d091739](d091739)) * **external-dns:** delete google provider ([94cf414](94cf414)) * **external-dns:** fix init script ([a2c35fd](a2c35fd)) * **externaldns:** support multi external dns ([#97](#97)) ([3ddbd8e](3ddbd8e)) * false redundacy ([199d908](199d908)) * false redundacy ([8c5b585](8c5b585)) * false redundacy ([7040143](7040143)) * I'm adding support for Prometheus Operator ([f1c6e08](f1c6e08)) * I'm adding support for Prometheus Operator ([9e1db19](9e1db19)) * I'm adding support for Prometheus Operator ([11557ea](11557ea)) * **infra:** add v1 to namespace external dns ([ae35596](ae35596)) * **main:** add PR to execute linter& docs ([81ebff6](81ebff6)) * **main:** rollback ([1681548](1681548)) * **oci:** add support for oci ([#146](#146)) ([ffaa72d](ffaa72d)) * oid enabled ([0f48c61](0f48c61)) * pipeline ([25c0a28](25c0a28)) * **pre-commit:** add conventional commits validation ([8612274](8612274)) * **promnetheus:** edit variables ([#56](#56)) ([45ddc88](45ddc88)) * **provider:** add support for azure devops ([#133](#133)) ([e0125d9](e0125d9)) * **release:** edit yaml release ([#58](#58)) ([b50b97e](b50b97e)) * **scope definition:** edit lifecycle ([96d482a](96d482a)) * **scope-definition-agent:** fix data http templates ([f89a4ef](f89a4ef)) * **scope-definition:** fix agent telemetry config ([#50](#50)) ([cd59a81](cd59a81)) * **scope:** parameterize repository values ([#110](#110)) ([297c1a3](297c1a3)) * service definition and service association channel ([#121](#121)) ([44e6a8e](44e6a8e)) * **tofu:** apply tofu fmt ([d2c4f80](d2c4f80)) * **tofu:** resolve conflicts ([61692e3](61692e3)) * **tofu:** run fmt ([371342b](371342b)) ### Bug Fixes * **acm:** fix logic ([cafffea](cafffea)) * add disclaimer for registration_enabled usage ([ac1fd0a](ac1fd0a)) * add validation for virtual_network_links ([76438d0](76438d0)) * added AZ private DNS variables ([8b2b714](8b2b714)) * **agent:** add extra-config variable ([1ef4815](1ef4815)) * **agent:** add permission to verifiedpermissions ([7d2c50c](7d2c50c)) * **agent:** add permission to verifiedpermissions ([#145](#145)) ([369012e](369012e)) * **agent:** fix repos extra variable ([dbda999](dbda999)) * **agent:** fix values tmpl ([b1044bc](b1044bc)) * **agent:** fix values tmpl ([26721ab](26721ab)) * **agent:** fix values tmpl ([3640da2](3640da2)) * **agent:** fix var repo extra ([bf989fa](bf989fa)) * **agent:** refactor values agent ([46023a8](46023a8)) * **agent:** upgrade helm chart version ([596e05f](596e05f)) * **aks:** add network contributor ([0305ade](0305ade)) * **aks:** add network contributor ([#114](#114)) ([1542270](1542270)) * **alb-controller:** add perdiod sync variable ([f96191b](f96191b)) * **alb-controller:** add policy to alb controller ([63596f3](63596f3)) * **alb-controller:** fix sa to v1 ([ab6f557](ab6f557)) * **alb-controller:** fix sa to v1 ([8a9d1d3](8a9d1d3)) * **asset:** fix naming policies ([743e5ba](743e5ba)) * **asset:** fix naming policies ([6ecff04](6ecff04)) * **aws-region:** use .name instead of .region attribute in aws_region data source ([0d0912e](0d0912e)) * **aws-region:** use .name instead of .region attribute in aws_region data source ([#154](#154)) ([7094878](7094878)) * **azure-aks:** add role to vnet ([b40d33d](b40d33d)) * **azure-aks:** principal_id variable ([6e3d54c](6e3d54c)) * **azure-aks:** principal_id variable ([6232bf0](6232bf0)) * **base-gateways:** add annottaion to LB use subnet private ([8e3b09e](8e3b09e)) * **base-iam:** fix naming policies to multiple cluster ([c1d5701](c1d5701)) * **base:** adding gateway name parameter ([#139](#139)) ([a47a299](a47a299)) * **base:** disabled webhook option ([2496ba4](2496ba4)) * **base:** fix naming k8s-provider ([d89fe19](d89fe19)) * **base:** remove provider nullplarform ([#69](#69)) ([bb376e9](bb376e9)) * **base:** update version chart ([0bc1fbd](0bc1fbd)) * **base:** update version chart ([#116](#116)) ([26a1034](26a1034)) * **base:** update version heml chart ([b8bec08](b8bec08)) * **base:** upgrade version helm ([87c1aae](87c1aae)) * **cert manager:** fix linter ([#95](#95)) ([260d4c2](260d4c2)) * **cert-manager-iam:** fix allow hosted zone ([e819f79](e819f79)) * **cert-manager-iam:** fix sa name & add private zone managed ([5142697](5142697)) * **cert-manager:** add helm options ([7bd7b2c](7bd7b2c)) * **cert-manager:** fix namespace error and improve configuration ([7d2e296](7d2e296)) * **cert-manager:** fix namespace error and improve configuration ([4af6c98](4af6c98)) * **cert-manager:** remove deafult to mandatory variables ([351a7f9](351a7f9)) * **cert-manager:** remove IRSA ([6383227](6383227)) * **cert-manager:** resolve conflicts ([c6a3cb7](c6a3cb7)) * **chart-base:** add istio gateway security groups ([#143](#143)) ([03fa7be](03fa7be)) * commons changes readme ([ee79884](ee79884)) * commons changes readme ([3207ce2](3207ce2)) * correct typo in private_dns_resource_group_name description ([d528e53](d528e53)) * correct YAML indentation in agent template ([0503606](0503606)) * **eks:** add aditional security gorup ([2c44375](2c44375)) * **eks:** disable node security group to avoid ALB controller conflict ([#137](#137)) ([8cbe80b](8cbe80b)) * **eks:** segretate logic of node groups ([0937b93](0937b93)) * external-dns secret and namespace depends ([fc4da0b](fc4da0b)) * external-dns secret and namespace depends ([4ee0bbd](4ee0bbd)) * **external-dns-iam:** add trust policy ([4fc890f](4fc890f)) * **external-dns:** add action external dns policy ([4752701](4752701)) * **external-dns:** add manage private zone ([e0fbfff](e0fbfff)) * **external-dns:** add rbac ([#141](#141)) ([ea5c5bb](ea5c5bb)) * **external-dns:** add rbac to manage dns endpoints ([546876e](546876e)) * **external-dns:** add source httproute ([ba3b6fc](ba3b6fc)) * **external-dns:** add source variable ([aed8c25](aed8c25)) * **external-dns:** change policy to variable ([#73](#73)) ([739ae02](739ae02)) * **external-dns:** delete namespace manifest ([17b7495](17b7495)) * **external-dns:** fix external dns varaible type ([d44879c](d44879c)) * **external-dns:** fix external dns varaible type ([#128](#128)) ([af26c59](af26c59)) * **external-dns:** fix gsa_email variable ([d0e20fe](d0e20fe)) * **external-dns:** fix name chart ([b0c4d05](b0c4d05)) * **external-dns:** fix name chart ([01852d9](01852d9)) * **external-dns:** fix rbac to dnsendpoint ([1e26890](1e26890)) * **external-dns:** fix sources ([fe50c75](fe50c75)) * **external-dns:** move zone_type to variable ([bd3ac1b](bd3ac1b)) * **external-dns:** remove regsitry ([73cf983](73cf983)) * **external-dns:** resolve conflicts ([4c9a701](4c9a701)) * **external-dns:** rollback name dns provider ([16ecdd9](16ecdd9)) * **external-dns:** sa name ([e0bdcb6](e0bdcb6)) * **external-dns:** set default value ([#126](#126)) ([c652f64](c652f64)) * **external-dns:** single managed hosted zone ([8dd9c20](8dd9c20)) * **gke:** add protection destroy as false ([#102](#102)) ([26f0788](26f0788)) * **helm:** add options to applies ([987403a](987403a)) * **helm:** add options to applies ([b64a340](b64a340)) * **iam-cert-manager:** arn role ([f9e27bd](f9e27bd)) * **iam-cert-manager:** arn role ([e0e112c](e0e112c)) * **iam-cert-manager:** arn role ([65c5fb0](65c5fb0)) * **iam-cert-manager:** arn role ([4ea5275](4ea5275)) * **iam-cert-manager:** arn role ([63959ac](63959ac)) * **infra:** fix namespace name ([5f22a63](5f22a63)) * **istio:** wait for condition ([8cbe4e1](8cbe4e1)) * make virtual_network_links required without default ([329f5a5](329f5a5)) * **null-code_reposotory:** update readme.md ([c478123](c478123)) * **nullplatform-base:** add security groups to gateways ([2b72d60](2b72d60)) * **nullplatform:** rename api key to SCOPE_DEFINITION_AGENT_ASSOCIATION ([d23557a](d23557a)) * only azure, no gcp ([b30004c](b30004c)) * only azure, no gcp ([4556484](4556484)) * Parameterize ingress controller configuration ([da89217](da89217)) * **private_dns:** make virtual_network_links required and update example ([c75b08f](c75b08f)) * **prometheus:** fix variable ([#60](#60)) ([aa177c0](aa177c0)) * **release:** fix commit message ([#131](#131)) ([eb4e239](eb4e239)) * **release:** fix commit message ([#88](#88)) ([5926b7b](5926b7b)) * remove cross-variable validations ([8d4f5cd](8d4f5cd)) * remove cross-variable validations from agent and external_dns ([64f34c5](64f34c5)) * remove unnecessary information from the readme ([ead4e24](ead4e24)) * remove version argument from git source module ([ed82438](ed82438)) * remove version argument from git source module ([041f1ba](041f1ba)) * rename agent API key to AGENT-ASSOCIATION with minimal permissions ([#92](#92)) ([1fb44b2](1fb44b2)) * rename api key to SCOPE_DEFINITION_AGENT_ASSOCIATION ([#117](#117)) ([1ed79ba](1ed79ba)) * **route53:** disable output acm ([1dc1601](1dc1601)) * **route53:** disabled ACM ([413144d](413144d)) * **scope_definition_agent_association:** add devops role to channel API key ([dc92016](dc92016)) * **scope_definition_agent_association:** use ops role instead of devops ([6012a4a](6012a4a)) * **scope:** Add support for icon and annotations in service action spec definition ([#82](#82)) ([5c7c1bb](5c7c1bb)) * **scope:** delete wrong file ([e0f3da8](e0f3da8)) * **scope:** fix naming reference scope association ([4f7059e](4f7059e)) * **scope:** fix naming reference scope association ([#75](#75)) ([fec4c30](fec4c30)) * **scope:** Fixing typo in annotation in scope definition module ([#85](#85)) ([75a0d48](75a0d48)) * secret ([6360c94](6360c94)) * secret ([5f0885c](5f0885c)) * **service-definition:** simplify link specifications to use only links/ directory ([#149](#149)) ([6db7d61](6db7d61)) * standardize module variables and documentation ([9740af8](9740af8)) * standardize module variables and documentation ([df30a24](df30a24)) * **tofu-modules:** update varibles & readme ([8de37f1](8de37f1)) * **tofu:** fmt ([a9da839](a9da839)) * **tofu:** resolve conflicts ([013628f](013628f)) * trigger release ([#150](#150)) ([eaa6a66](eaa6a66)) * unify cert-manager templates to handle all cloud providers ([e38db55](e38db55)) * update cert-manager webhook config and improve README ([945f9a7](945f9a7)) * update cert-manager webhook config and improve README ([cd36b2b](cd36b2b)) * update to v0.15.0 and replace resource_group_name for parent_id ([535b4e8](535b4e8)) * update to v0.15.0 and replace resource_group_name for parent_id ([#53](#53)) ([fe32430](fe32430)) * use ternary operator instead of coalesce for null ([53ec48f](53ec48f)) * **workflows:** add condition branch release ([cc4b976](cc4b976)) * **workflows:** add condition branch release ([855d6f6](855d6f6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix external DNS policy to managed DNS record that a variable