Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(lint): new rules and fix lint error #704

Merged
merged 4 commits into from
Apr 26, 2020
Merged

style(lint): new rules and fix lint error #704

merged 4 commits into from
Apr 26, 2020

Conversation

c-jacquin
Copy link
Collaborator

ts parser everywhere

run lint on all files and manually fix what was needed

@c-jacquin c-jacquin requested a review from nukeop April 26, 2020 16:53
@c-jacquin c-jacquin marked this pull request as draft April 26, 2020 17:40
@c-jacquin
Copy link
Collaborator Author

looks like lint-staged works fine now

@nukeop
Copy link
Owner

nukeop commented Apr 26, 2020

Thanks, passes CI now. Can we merge it or do you want to add something?

@c-jacquin c-jacquin marked this pull request as ready for review April 26, 2020 21:12
@c-jacquin
Copy link
Collaborator Author

its ok i just forgot to remove the draft tag

@nukeop nukeop merged commit 73fc1cf into master Apr 26, 2020
@hixio-mh hixio-mh mentioned this pull request Jan 21, 2021
Merged
@haidang666 haidang666 deleted the fix/lint branch June 20, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nukeop nukeop Awaiting requested review from nukeop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-jacquin @nukeop