645 searchdropdown #690
Merged
645 searchdropdown #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nukeop
reviewed
Apr 15, 2020
nukeop
added
the
needs changes
|
Thanks, I tested it and it works ok, it leaves us in a nice place to start work on search history. Thank you for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #645.
Unfortunately I haven't had much time to work on this so for now I have tied it off with a working dropdown that will display when a user clicks inside the search box and closes when either ESC is pressed or the user clicks away into the main window.
Currently since there is no content inside the search dropdown nothing is displayed but the functionality is there.
Hopefully the structure is correct for the project; I'm unfamiliar with the setup so let me know if there's anything you want moved around or done in another way and any feedback is appreciated.