Remove '&' from last.fm track name #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trekiteasy
reviewed
Feb 8, 2019
app/rest/LastFm.js
Outdated
| @@ -12,7 +12,7 @@ function makeLastfmRequest (parameters) { | |||
| } | |||
|
|
|||
| function searchTracks (terms, limit = 30) { | |||
| let parameters = 'track.search&track=' + encodeURI(terms); | |||
| let parameters = 'track.search&track=' + encodeURI(terms).replace('&', ''); | |||
There was a problem hiding this comment.
I agree with the issue, but would rather use encodeURIComponent(terms) in order to deal with other characters such as "#", "/" ,"." or ":"
There was a problem hiding this comment.
yeah, that´s a better solution... I´ve updated the file
|
Thanks for spotting this. |
nukeop
added a commit
that referenced
this pull request
Sep 30, 2019
Remove '&' from last.fm track name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently last.fm returns wrong results if the track name contains a '&'-symbol, because it tries to get results from an url like this:
http://ws.audioscrobbler.com/2.0/?method=track.search&track=Artist1%20&%20Artist2%20Trackname&limit=[...]so basically everything after Artist1%20 gets cut off, which leads to wrong results in many cases. This issue happened only after searching for a youtube url.
Example:
Enter this link in the search bar: https://www.youtube.com/watch?v=hj4g-hHw9CI (track name is Deadly Guns & E-Force - Invincible)
The song result is Deadly Guns - Deadly Venoms (Official Snakepit 2017 Anthem) because it searches only for Deadly Guns.