Removed a few duplicated code lines #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function 'replaceQuery' (because the functions 'addToken' and 'addKeys' had a few duplicated code lines) Function 'search' instead of three functions with almost the same code in it(searchAlbums, searchArtists, searchReleases)
Removed a few duplicated code lines
Use function 'search' instead
nukeop
reviewed
Feb 6, 2019
|
Is this ready to be merged, or are you still working on it? |
|
I´ve shortened the code like you suggested, so it can be merged now... |
|
If you open a pull request, pushing to the branch that's in that pull request will also add new changes to the pull request itself. But it's alright anyway. Thanks for your help and I hope your first contributions were enjoyable, it's always very cool to see new people commit something. |
nukeop
added a commit
that referenced
this pull request
Sep 30, 2019
Removed a few duplicated code lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function 'replaceQuery' because the functions 'addToken' and 'addKeys' had a few duplicated code lines
Function 'search' instead of three functions with almost the same code in it(searchAlbums, searchArtists, searchReleases)