Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded 'react-range-progress' #220

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Downgraded 'react-range-progress' #220

merged 2 commits into from
Jan 29, 2019

Conversation

Chandankkrr
Copy link
Contributor

Fix for failing build due to babel preset "stage-0"

@Chandankkrr
Copy link
Contributor Author

@nukeop Running npm run build:dist locally builds fine with react-range-progress version 4.0.2 but fails in Travis CI.

One of the possible solution is to install babel-preset-stage-0 but it's not ideal.

Any possible solutions to fix this?

@nukeop
Copy link
Owner

nukeop commented Jan 29, 2019

Feel free to add that, no problem.

@Chandankkrr
Copy link
Contributor Author

Ok, the issue is fixed now. I am guessing the build failure for OSX is a known issue?

@nukeop
Copy link
Owner

nukeop commented Jan 29, 2019

Yeah, it is. electron-builder-related.

@Chandankkrr
Copy link
Contributor Author

Chandankkrr commented Jan 29, 2019

Ok cool. This PR is ready to be merged in.

@nukeop nukeop merged commit 302f762 into nukeop:master Jan 29, 2019
nukeop added a commit that referenced this pull request Sep 30, 2019
Downgraded 'react-range-progress'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants