Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Seekbar Container More Visible #183

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Make Seekbar Container More Visible #183

merged 3 commits into from
Jan 23, 2019

Conversation

1yzo
Copy link

@1yzo 1yzo commented Jan 23, 2019

Problem

  • I am having a lot of trouble putting my cursor on the seekbar when trying to skip through songs.

Solution

  • I went ahead and changed the seekbar_container background color to make it more visible.
  • I used the same background color used for the volume-slider-container.

@nukeop
Copy link
Owner

nukeop commented Jan 23, 2019

This is a pretty standard design, the seekbar is supposed to be invisible until you play something. If you need to click it, the cursor changes to a pointer when you hover over it. Could you post a quick screenshot of your change before we decide to merge?

@1yzo
Copy link
Author

1yzo commented Jan 23, 2019

image

@nukeop
Copy link
Owner

nukeop commented Jan 23, 2019

Looks neutral enough, I don't have strong feelings either way.

@nukeop nukeop merged commit 8ac07b1 into nukeop:master Jan 23, 2019
@1yzo
Copy link
Author

1yzo commented Jan 23, 2019

Cool, thanks. It just always takes me a significant amount of time to get the pointer to actually show up 😂.

nukeop added a commit that referenced this pull request Sep 30, 2019
Make Seekbar Container More Visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants