Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux typing: Player #1284

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Redux typing: Player #1284

merged 1 commit into from
Jun 3, 2022

Conversation

baduts
Copy link
Contributor

@baduts baduts commented Jun 1, 2022

Changes

Changed player actions to typesafe-actions
Fully typed reducer

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1284 (c04bd9d) into master (976d7d2) will increase coverage by 0.03%.
The diff coverage is 69.49%.

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   69.52%   69.56%   +0.03%     
==========================================
  Files         332      332              
  Lines        6101     6098       -3     
  Branches      418      419       +1     
==========================================
  Hits         4242     4242              
+ Misses       1515     1511       -4     
- Partials      344      345       +1     
Impacted Files Coverage Δ
...ges/app/app/containers/PlayerBarContainer/hooks.ts 83.51% <0.00%> (ø)
...s/app/app/containers/TrackTableContainer/index.tsx 79.24% <0.00%> (ø)
packages/ui/lib/components/AlbumGrid/index.tsx 65.38% <0.00%> (ø)
packages/app/app/actions/player.ts 68.75% <68.75%> (ø)
packages/app/app/actions/queue.ts 68.42% <71.42%> (-0.23%) ⬇️
packages/app/app/reducers/player.ts 73.68% <80.00%> (ø)
packages/app/app/actions/actionTypes.ts 88.70% <88.88%> (+0.01%) ⬆️
packages/app/app/components/PlaylistView/index.tsx 100.00% <100.00%> (ø)
...ges/app/app/containers/AlbumViewContainer/hooks.ts 95.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976d7d2...c04bd9d. Read the comment docs.

@nukeop nukeop merged commit b6c6b63 into nukeop:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants