Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads tests and improvements #1116

Merged
merged 2 commits into from
Dec 5, 2021
Merged

Downloads tests and improvements #1116

merged 2 commits into from
Dec 5, 2021

Conversation

nukeop
Copy link
Owner

@nukeop nukeop commented Dec 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #1116 (5ed4fa1) into master (108ba85) will increase coverage by 1.04%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   61.88%   62.92%   +1.04%     
==========================================
  Files         283      284       +1     
  Lines        5187     5190       +3     
  Branches      363      365       +2     
==========================================
+ Hits         3210     3266      +56     
+ Misses       1671     1617      -54     
- Partials      306      307       +1     
Impacted Files Coverage Δ
packages/app/test/testUtils.tsx 92.85% <ø> (ø)
...p/app/components/Downloads/DownloadsList/index.tsx 80.00% <62.50%> (ø)
...p/app/components/Downloads/DownloadsItem/index.tsx 92.30% <80.00%> (ø)
packages/app/app/actions/downloads.ts 76.05% <83.33%> (+26.05%) ⬆️
...app/components/Downloads/DownloadsHeader/index.tsx 92.85% <92.85%> (ø)
packages/app/app/actions/settings.ts 52.94% <100.00%> (+11.76%) ⬆️
packages/app/app/components/Downloads/index.tsx 85.71% <100.00%> (ø)
...es/app/app/containers/DownloadsContainer/index.tsx 100.00% <100.00%> (ø)
packages/app/app/selectors/downloads.ts 100.00% <100.00%> (ø)
packages/app/test/storeBuilders.ts 82.85% <100.00%> (+1.60%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108ba85...5ed4fa1. Read the comment docs.

@nukeop nukeop merged commit d64590e into master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant