-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prospective solution for livestream appearance #1077
Merged
Merged
Changes from 1 commit
Commits
Show all changes
84 commits
Select commit
Hold shift + click to select a range
2bd857c
Travis
dc9e5d3
Travis
ca7e4d0
Build
10d557f
build
e69e606
Windows
2795303
Tests
524bdf6
No cache
0b90ba2
npm install
c0d03df
Linux
cf41bc2
build
11d8e31
build
0aa17c1
travis
0c55278
windows
50dcb22
build
dd89746
linux
9d47b76
test
9a356ec
export
9b1b6b8
export
2980902
node
66591c5
windows
a8a4fc1
travis_wait linux
42ff4f3
tests
73abe93
javascript
466faae
sudo
61fca26
script
7f01d81
local_dir
7a9a14d
commit
88aaf8f
commit
271006f
Merge pull request #3 from nukeop/master
jreiser1 3afc999
Combining all Travis setup commits
4a2960c
Changed to TypeScript (#1039)
Hardik-hi cf9da46
Skip Sponsorblock setting options (#1047)
haidang666 e9c2b53
Increased z-index of plugin dropdown
Hardik-hi eeb2f2e
Merge branch 'master' of https://github.com/MSU-CS4360-Nuclear/nuclear
jreiser1 320722d
Fixed typo in Equalizer presets
jreiser1 bbeb014
Fixed incorrect album year display
jreiser1 c7c8f79
Copying Seekbar code to start on LivestreamSeekbar
jreiser1 678a8d1
Potential Resolution for Nuclear issues #1044 & #1007
39a44d6
commenting out boilerplate code
jreiser1 2fb1be0
Merge pull request #10 from MSU-CS4360-Nuclear/livestream-fix
1lluzi0nzz 21ccac1
Removed boilerplate Livestream code and fixed album year implementation
jreiser1 b3b0ff5
update .gitignore
jreiser1 92f1e5e
deleting .vs directory
jreiser1 56dabcf
Delete package-lock.json
jreiser1 78d0128
Delete deeper package-lock.json
jreiser1 0610f55
updated .gitignore again
jreiser1 aa1a216
Merge branch 'master' of https://github.com/MSU-CS4360-Nuclear/nuclear
jreiser1 cc0e20f
Delete .travis.yml
jreiser1 6b06985
Update package.json
1lluzi0nzz 2ed3afa
Fix package-lock.json
1lluzi0nzz aadd9ae
Re-adding old package-lock.json
jreiser1 bb780c9
Update .gitignore
1lluzi0nzz 6f63d8c
Update index.ts
1lluzi0nzz 5b0bbcd
Merge branch 'nukeop:master' into master
jreiser1 69c82d2
set up live timestamps
jreiser1 702e640
add optional parameter & fix UI transfer between live and regular songs
jreiser1 a32cdf9
added livestream seekbar functionality
jreiser1 8d3b5ee
adding unit tests for formatDuration optional parameter
jreiser1 ae9db00
Merge branch 'nukeop:master' into master
jreiser1 304cd20
Queue will show the duration of LIVE tracks as LIVE instead of 00:00
4e6678c
Adjusted PlayQueueContainer Snapshot Tests to reflect LIVE where they…
b7e11e4
livestreamfix2 > master, PR candidate for nuclear issue #970
1lluzi0nzz e711167
Merge branch 'nukeop:master' into master
1lluzi0nzz d27bb01
Logging when livestream is NaN to fix normal song -> livestream bug
jreiser1 6a49c74
Merge pull request #14 from MSU-CS4360-Nuclear/livestreamfix2
jreiser1 c4fe0a7
Livestream bottom right -'LIVE' > 'LIVE'
dba5177
adding item for "Live" timestamp to language files
jreiser1 8d045db
removing unnecessary logging
jreiser1 091d160
Merge pull request #15 from MSU-CS4360-Nuclear/livestreamfix2
jreiser1 1d313f0
QueueItem duration is localized with livestreams ie Live, En Vivo, etc
3706cd0
Adding check for NaN timeToEnd to fix seekbar UI bug
jreiser1 78136ba
Merge pull request #16 from MSU-CS4360-Nuclear/livestreamfix2
jreiser1 569828e
adding localization to live timestamps
jreiser1 07b413f
adding localization to live timestamps
jreiser1 47aa7d7
Removing live keys from all language files except en.json
7b02ff6
livestream > isLivestream, Reverted change in QueueItem.tsx (change i…
fc6023f
1 Line for isLivestream & fill
3d260f5
hooks.ts type errors
5b5a954
Seekbar Type Errors
8ed3641
Merge branch 'nukeop:master' into master
1lluzi0nzz 2a6d834
Seekbar types
5412342
formatDuration test for string 'test' should now be 'test' for Livest…
ff2f0dd
Fixed Snapshot tests
67c22eb
revert album_year test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
livestream > isLivestream, Reverted change in QueueItem.tsx (change i…
…s in components/PlayQueue)
- Loading branch information
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should never mutate props. Instead of doing all this, you should pass different props to child elements. You can also determine whether we're dealing with a live stream or not in a single line.
E.g.:
Then depending on this variable, pass a different fill value to the seekbar:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const isLivestream = isNan(timetoEnd) || isString(timeToEnd);
Almost have something like this working, above line fills SeekBar by default but the line in our repo now has it empty by default.
fill={isLivestream ? 100 : fill}
I like this line, I've added it to the PR.
Thanks for reviewing!