Resolution for Issues #1044 & #1007 #1057
Conversation
Merge with main project master branch
Travis Travis Build build Windows Tests No cache npm install Linux njs 12.14.1 build build travis windows build linux test export export node windows travis_wait linux tests javascript sudo script local_dir commit commit
Merging Livestream UI work into Master. Branch livestream-fix
IDE config, don't need
leaving out of pull request
leaving out of pull request
Package.json
accidentally pulled them out completely, don't want to mess with main repo
|
There's a ton of commits mainly because we were messing with our configuration stuff, setting up our own CI, and making sure that our changes wouldn't interfere with your configuration. We would be happy to squash these down if you would like. |
|
Thanks for contributing. Don't worry about the number of commits, I'll just squash them. I'll run the CI now and will review it soon. |
.gitignore
Outdated
|
|
||
| #package-lock | ||
| package-lock.json |
There was a problem hiding this comment.
Please don't commit these (package-lock and package.json) as they need to be update if we install new packages.
There was a problem hiding this comment.
These lines have been taken out of .gitignore, should be tracked again.
Thanks!
| @@ -39,7 +39,8 @@ class Config { | |||
| this.youtubeSearch = 'https://www.googleapis.com/youtube/v3/search?part=id,snippet&type=video&maxResults=50&q='; | |||
| this.supportedFormats = _.uniq(pkg.build.fileAssociations.map(({ ext }) => ext)); | |||
|
|
|||
| const iconPath = path.resolve(__dirname, this.isProd() ? 'resources' : '../resources/media'); | |||
| // const iconPath = path.resolve(__dirname, this.isProd() ? 'resources' : '../resources/media'); | |||
| const iconPath = path.resolve(__dirname, this.isProd() ? '../../../resources/media' : '../resources/media'); | |||
There was a problem hiding this comment.
Thanks for getting to the bottom of this. Could you please delete the commented out line?
There was a problem hiding this comment.
I removed that comment.
Thanks for reviewing this.
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
- Coverage 61.43% 61.42% -0.01%
==========================================
Files 280 280
Lines 5002 5001 -1
Branches 318 318
==========================================
- Hits 3073 3072 -1
Misses 1662 1662
Partials 267 267
Continue to review full report at Codecov.
|
package & package-lock will be tracked.
Removing commented line.
|
Thanks for solving this! |
Hello, I think this PR should close out a couple issues in the project as well as present albums in a cleaner way:
Tray & Taskbar Icons:
Album Year Display:
Full Notes:
Album Year instead of Timestamp
Fixed Typo in the equalizer presets
Issue with the Taskbar Icon (Taskbar Icon not rendering correctly/completely #1044) should be resolved (Verified on Windows)
Issue with the Tray Icon (Tray icon work in development not in production build #1007) not working correctly on release builds should be resolved (Verified on Windows)