Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to delete albums from favorite albums page #723

Closed
skyawmyint opened this issue Jun 4, 2020 · 16 comments · Fixed by #790
Closed

[Feature Request] Ability to delete albums from favorite albums page #723

skyawmyint opened this issue Jun 4, 2020 · 16 comments · Fixed by #790
Labels
feature request This is a request for the addition of some feature. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.

Comments

@skyawmyint
Copy link

Description of Improvement
Currently, the only way to delete an album from the favorite albums tab is to click on the album to go into the album page and unstar it as seen in the second screenshot.

album-star

As show on the first screenshot below, there is no option to delete it in the favorite album tab. A way to improve it to make it easier and less screens to delete it from the favorite album list is to add a delete album option or an X mark in that list. I think maybe this is something to implement as the app grows with more users and people start to have tons of favorite albums to their collection.

favorite album page

@nukeop nukeop added feature request This is a request for the addition of some feature. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. labels Jun 9, 2020
@WildLeons
Copy link

Hello, I would like to work on this one if possible.

@nukeop
Copy link
Owner

nukeop commented Jun 12, 2020

I already started some dev work on it, I'm adding a button in the corner of those cards that will pop up a menu on clicking it. If you'd like, I can let you know once I'm finished with this so you can add the delete button to the menu in this screen.

@WildLeons
Copy link

WildLeons commented Jun 15, 2020 via email

@ghost
Copy link

ghost commented Jun 29, 2020

Hi ! Can I join on this ? is my first contribution and having people guiding me I think would be a good start
Regards

@nukeop
Copy link
Owner

nukeop commented Jun 29, 2020

I turned this into a larger task of overhauling certain components, such as cards and the bottom bar, and have already done a lot of work on that, but I'm still not finished with it. I'll try to close this by the end of this week and will let you know once I'm done.

@kartikcode
Copy link

Hi everyone! I am newbie to this project and would like to contribute to it.
I just wanted to confirm if @nukeop is still working on it? If not, I would love to work on it.

@nukeop
Copy link
Owner

nukeop commented Aug 20, 2020

Hi everyone! I am newbie to this project and would like to contribute to it.
I just wanted to confirm if @nukeop is still working on it? If not, I would love to work on it.

I made some changes on another branch but decided to scrap them. If you want to pick this up you're more than welcome to. Let's start with adding some sort of a popup with a menu to the album cards.

@kartikcode
Copy link

Oh, cool. I will right away start with this issue.

@kartikcode
Copy link

Also, what all options are you wanting to add to the menu list? @nukeop

@nukeop
Copy link
Owner

nukeop commented Aug 26, 2020

For now, just removing from favorites. Later on we can think about e.g. add all to queue.

@sirdarthvader
Copy link

@nukeop Is this issue assigned to someone? If not I would like to work on it. Let me know at the earliest.

@nukeop
Copy link
Owner

nukeop commented Oct 4, 2020

Nope, not yet. Feel free to take it.

@sirdarthvader
Copy link

@nukeop can you assign this to me.

@erikujczo
Copy link

@sirdarthvader Hey are you still working on this one? If not, I would like to take it 👍

@Edu93Jer
Copy link

Edu93Jer commented Dec 1, 2020

Hi, everyone I am newbie to this project and would like to contribute to it.
Can you put me in line, is anyone working on the issue?

@erikujczo
Copy link

Hi @Edu93Jer I already made the PR but it’s still waiting for reviews. Feel free to check my solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request This is a request for the addition of some feature. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants