-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Ability to delete albums from favorite albums page #723
Comments
Hello, I would like to work on this one if possible. |
I already started some dev work on it, I'm adding a button in the corner of those cards that will pop up a menu on clicking it. If you'd like, I can let you know once I'm finished with this so you can add the delete button to the menu in this screen. |
Hi,
Yes, I'd like to add this button when you're done.
In the meantime, can I work on that feature ?
#722
Le ven. 12 juin 2020 à 21:33, nukeop <notifications@github.com> a écrit :
… I already started some dev work on it, I'm adding a button in the corner
of those cards that will pop up a menu on clicking it. If you'd like, I can
let you know once I'm finished with this so you can add the delete button
to the menu in this screen.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#723 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP5D3GMTYD63C5XBMUQHO6DRWJ7HXANCNFSM4NSFT46Q>
.
|
Hi ! Can I join on this ? is my first contribution and having people guiding me I think would be a good start |
I turned this into a larger task of overhauling certain components, such as cards and the bottom bar, and have already done a lot of work on that, but I'm still not finished with it. I'll try to close this by the end of this week and will let you know once I'm done. |
Hi everyone! I am newbie to this project and would like to contribute to it. |
I made some changes on another branch but decided to scrap them. If you want to pick this up you're more than welcome to. Let's start with adding some sort of a popup with a menu to the album cards. |
Oh, cool. I will right away start with this issue. |
Also, what all options are you wanting to add to the menu list? @nukeop |
For now, just removing from favorites. Later on we can think about e.g. add all to queue. |
@nukeop Is this issue assigned to someone? If not I would like to work on it. Let me know at the earliest. |
Nope, not yet. Feel free to take it. |
@nukeop can you assign this to me. |
@sirdarthvader Hey are you still working on this one? If not, I would like to take it 👍 |
Hi, everyone I am newbie to this project and would like to contribute to it. |
Hi @Edu93Jer I already made the PR but it’s still waiting for reviews. Feel free to check my solution. |
Description of Improvement
Currently, the only way to delete an album from the favorite albums tab is to click on the album to go into the album page and unstar it as seen in the second screenshot.
As show on the first screenshot below, there is no option to delete it in the favorite album tab. A way to improve it to make it easier and less screens to delete it from the favorite album list is to add a delete album option or an X mark in that list. I think maybe this is something to implement as the app grows with more users and people start to have tons of favorite albums to their collection.
The text was updated successfully, but these errors were encountered: