Repository navigation
Min dev node version - #773
Merged
Merged
Conversation
derekpierre
force-pushed
the
min-node-version
branch
from
April 10, 2026 18:05
0b559d7 to
780a0d7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## signing-epic #773 +/- ##
===============================================
Coverage ? 90.81%
===============================================
Files ? 98
Lines ? 8629
Branches ? 567
===============================================
Hits ? 7836
Misses ? 750
Partials ? 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
derekpierre
marked this pull request as ready for review
April 10, 2026 18:33
derekpierre
requested review from
KPrasch,
Copilot,
cygnusv,
theref and
vzotova
April 10, 2026 18:34
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s development/CI Node.js baseline in response to Node 18 reaching end-of-life and incompatibilities with the current Vitest-based test suite.
Changes:
- Bump the dev Node version in
.nvmrcfrom 18 to 22. - Update GitHub Actions CI matrices to run on newer Node versions (main CI: 22/24; npm package check: 22).
- Adjust a Vitest mock call-site to avoid using
Array.prototype.at()when retrieving the latest mock call.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/taco/test/taco-sign.test.ts |
Replaces .at(-1) with an index-based last-call lookup in a test. |
.nvmrc |
Updates local/dev Node version to 22. |
.github/workflows/npm.yml |
Updates the npm package validation job to run on Node 22.x. |
.github/workflows/main.yml |
Updates main CI Node matrix to 22.x and 24.x. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Don't include node v25 which has a change where node's built-in localStorage can interfere with the browser-like one.
derekpierre
force-pushed
the
min-node-version
branch
from
April 10, 2026 19:00
53c17fe to
7eaa8f3
Compare
4 tasks
vzotova
approved these changes
Apr 13, 2026
cygnusv
approved these changes
Apr 14, 2026
2 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
vitest(our test suite). Update min dev node version to be 22. This a dev version update but does not enforce use of this newer version for users of the library i.e. library runtime might still work fine on Node 18.Issues fixed/closed:
Why it's needed:
Notes for reviewers:
Those with more Typescript knowledge can comment on best practices here.