Add optional viem support for encryption and decryption operations #692

Muhammad-Altabba · 2025-08-12T16:44:56Z

Type of PR:

Bugfix
Feature
Documentation
Other

Required reviews:

1
2
3

What this does:

High-level idea of the changes introduced in this PR. List relevant API
changes (if any), as well as related PRs and issues.

Issues fixed/closed:

Closes https://github.com/nucypher/sprints/issues/212

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network. E.g.,
if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on? Is there a particular commit/function/section
of your PR that requires more attention from reviewers?

…provider

- Added eslint disable comments for necessary any types in dynamic viem type declarations - Fixed import order in examples and tests - Added file-level eslint disables for complex wrapper implementations - Resolved all lint errors while maintaining functionality

- Fixed eslint disable comment placement for any type assertions - Ensured all CI/CD lint checks pass successfully

(it was removed in another PR that is not yet merged with the target branch)

(to prevent making unnecessary network calls)

Muhammad-Altabba · 2025-08-14T08:44:45Z

packages/taco/integration-test/encrypt-decrypt.test.ts

@@ -128,65 +128,5 @@ describe.skipIf(!process.env.RUNNING_IN_CI)(
      // Verify decryption
      expect(decryptedMessageString).toEqual(messageString);
    }, 15000); // 15s timeout
-
-    test('should encrypt and decrypt according to wallet allowlist condition', async () => {


This test is no more working. And it has been already deleted at #688.

in addition to some minor changes like updating pinata library, add `downloadBytes` to the bas storage provider and add some constants and comments...

…classes

Copilot

Pull Request Overview

This PR adds optional viem support for encryption and decryption operations in the TACo SDK. It provides viem-compatible wrapper functions that internally convert viem objects to ethers.js objects for seamless integration with existing TACo functionality.

Key Changes

Added encryptWithViem() and decryptWithViem() functions as viem alternatives to existing ethers.js functions
Created viem wrapper utilities in shared package for consistent cross-package integration
Implemented ViemEIP4361AuthProvider for viem-native authentication support

Reviewed Changes

Copilot reviewed 20 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/taco/src/viem-taco.ts	Core viem encryption/decryption functions with type casting to ethers.js
packages/taco/src/wrappers/viem-wrappers.ts	TACo-specific viem wrapper implementations extending shared base classes
packages/shared/src/viem-utils.ts	Shared viem utilities with base provider and signer classes
packages/taco-auth/src/providers/viem/viem-auth-providers.ts	Viem-compatible EIP4361 authentication provider
packages/taco/test/viem-unit.test.ts	Unit tests for viem functionality with mocked adapters
packages/taco/integration-test/viem-encrypt-decrypt.test.ts	Integration tests for real viem encryption/decryption flows
packages/taco/VIEM_SUPPORT.md	Documentation for viem usage patterns and API reference

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T09:40:50Z

packages/taco/src/viem-taco.ts

+ * );
+ *
+
+ * ```


The JSDoc example comment is incomplete - it ends with an incomplete code block. Either complete the example or remove the trailing backticks.

Copilot · 2025-08-15T09:40:50Z

packages/shared/src/viem-utils.ts

+    const feeData = await this.viemPublicClient.getFeeHistory({
+      blockCount: 4,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      blockNumber: 'latest' as any,


Using 'as any' type assertion bypasses TypeScript safety. Consider using a proper type or checking if 'latest' is a valid blockNumber type for the getFeeHistory method.

Suggested change

blockNumber: 'latest' as any,

blockNumber: 'latest' as "latest",

Copilot · 2025-08-15T09:40:50Z

packages/shared/src/viem-utils.ts

+    try {
+      return await this.viemPublicClient.getEnsAddress({
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        name: name as any,


Using 'as any' type assertion bypasses TypeScript safety. Consider defining proper types for ENS name resolution or checking the expected type for the name parameter.

Suggested change

name: name as any,

name: name,

Muhammad-Altabba requested a review from Copilot August 12, 2025 16:44

Muhammad-Altabba marked this pull request as draft August 12, 2025 16:45

feat: add viem support with ethers.js adapter wrappers and viem auth …

b30259d

…provider

Muhammad-Altabba force-pushed the 691-add-optional-viem-support-for-encryption-and-decryption-operations branch from 6891988 to b30259d Compare August 12, 2025 16:47

This comment was marked as outdated.

Sign in to view

Muhammad-Altabba added 5 commits August 13, 2025 21:42

fix: resolve final lint issues in test files

a4dddad

- Fixed eslint disable comment placement for any type assertions - Ensured all CI/CD lint checks pass successfully

remove a test that no longer work

93626e1

(it was removed in another PR that is not yet merged with the target branch)

mock more functions at a unit test

322a843

(to prevent making unnecessary network calls)

increase a test timeout

be96e41

Muhammad-Altabba requested a review from Copilot August 13, 2025 21:07

This comment was marked as resolved.

Sign in to view

Muhammad-Altabba force-pushed the 691-add-optional-viem-support-for-encryption-and-decryption-operations branch 5 times, most recently from 61c4fda to 55fbaa2 Compare August 13, 2025 21:55

improve structure

b222cf7

Muhammad-Altabba force-pushed the 691-add-optional-viem-support-for-encryption-and-decryption-operations branch from 55fbaa2 to b222cf7 Compare August 13, 2025 22:03

Muhammad-Altabba commented Aug 14, 2025

View reviewed changes

Muhammad-Altabba requested a review from Copilot August 14, 2025 08:47

nucypher deleted a comment from Copilot AI Aug 14, 2025

This comment was marked as outdated.

Sign in to view

Muhammad-Altabba force-pushed the 691-add-optional-viem-support-for-encryption-and-decryption-operations branch 3 times, most recently from c364fbd to 7872080 Compare August 14, 2025 11:00

some improvements to viem check code and structure

0ab9cb3

Muhammad-Altabba force-pushed the 691-add-optional-viem-support-for-encryption-and-decryption-operations branch from 7872080 to 0ab9cb3 Compare August 14, 2025 11:07

Muhammad-Altabba requested a review from Copilot August 14, 2025 11:07

This comment was marked as resolved.

Sign in to view

Muhammad-Altabba added 2 commits August 14, 2025 13:29

update comments and docs

e2d0646

minor enhancement

323857f

Muhammad-Altabba requested a review from Copilot August 14, 2025 12:53

This comment was marked as outdated.

Sign in to view

Muhammad-Altabba referenced this pull request in fileverse/agents Aug 14, 2025

feat: use TACo encryption as an optional access control

8dd99c8

in addition to some minor changes like updating pinata library, add `downloadBytes` to the bas storage provider and add some constants and comments...

refactor: extract common viem provider/signer logic into shared base …

90c9e47

…classes

Muhammad-Altabba requested a review from Copilot August 14, 2025 21:56

This comment was marked as resolved.

Sign in to view

more cleanup refactoring

314a69c

Muhammad-Altabba requested a review from Copilot August 15, 2025 09:39

Copilot AI reviewed Aug 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add optional viem support for encryption and decryption operations #692

Add optional viem support for encryption and decryption operations #692

Uh oh!

Muhammad-Altabba commented Aug 12, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

Muhammad-Altabba Aug 14, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 15, 2025

Uh oh!

Copilot AI Aug 15, 2025

Uh oh!

Copilot AI Aug 15, 2025

Uh oh!

Uh oh!

+               * );
+               *
+               * ```

	blockNumber: 'latest' as any,
	blockNumber: 'latest' as "latest",

Add optional viem support for encryption and decryption operations #692

Are you sure you want to change the base?

Add optional viem support for encryption and decryption operations #692

Uh oh!

Conversation

Muhammad-Altabba commented Aug 12, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

Muhammad-Altabba Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!