WASM bindings #78
WASM bindings #78
Conversation
piotr-roslaniec
force-pushed
the
wasm-bindings
branch
2 times, most recently
from
1d6b304
to
87ad212
Compare
umbral-pre/src/bindings_wasm.rs
Outdated
|
|
||
| #[wasm_bindgen] | ||
| pub struct SecretKey { | ||
| backend: umbral_pre::SecretKey, |
There was a problem hiding this comment.
Why did you switch from anonymous fields to backend?
There was a problem hiding this comment.
I had some issues with serde_wasm_bindgen, where anonymous fields would not be properly serialized o JSON. But I don't think this is relevant anymore. And I'm going to switch to builder patterns anyway.
I will change it back.
| } | ||
|
|
||
| impl SecretKey { | ||
| pub fn inner(&self) -> &umbral_pre::SecretKey { |
There was a problem hiding this comment.
Is that for use in nucypher_core? Perhaps it can be done similarly to the Python bindings (AsBackend and FromBackend traits)
There was a problem hiding this comment.
I will try this out, thanks!
| } | ||
|
|
||
| #[wasm_bindgen] | ||
| #[derive(Serialize, Deserialize)] |
There was a problem hiding this comment.
Are those for use in nucypher_core as well?
umbral-pre/Cargo.toml
Outdated
| base64 = { version = "0.13", default-features = false, features = ["alloc"] } | ||
| pyo3 = { version = "0.15", optional = true } | ||
| js-sys = { version = "0.3", optional = true } | ||
| wasm-bindgen = {version = "0.2.74", optional = true } | ||
| wee_alloc = { version = "0.4", optional = true } |
There was a problem hiding this comment.
Does it need to be here? It's only used in umbral-pre-wasm
There was a problem hiding this comment.
wee_alloc can go, but I need to keep others there because I need #[wasm-bindgen] and mapping errors with js_sys::Error. I feel like this is similar to keeping pyo3 for python-bindings here, no?
There was a problem hiding this comment.
Ah yes, I agree about the other too, I was asking about wee_alloc specifically
|
@fjarri Thank you for your comments. I think some of the things you've pointed out will be solved when I switch some of the |
piotr-roslaniec
force-pushed
the
wasm-bindings
branch
from
d699a14
to
45331a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 67.75% 60.23% -7.52%
==========================================
Files 16 17 +1
Lines 1290 1451 +161
==========================================
Hits 874 874
- Misses 416 577 +161
Continue to review full report at Codecov.
|
piotr-roslaniec
force-pushed
the
wasm-bindings
branch
from
347814c
to
321cbc3
Compare
piotr-roslaniec
force-pushed
the
wasm-bindings
branch
from
e3092da
to
e4aba6b
Compare
Refers to: nucypher/nucypher-core#1