Introduce KeyFragID instead of using a Scalar for this purpose #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 94.83% 94.64% -0.19%
==========================================
Files 10 10
Lines 736 766 +30
==========================================
+ Hits 698 725 +27
- Misses 38 41 +3
Continue to review full report at Codecov.
|
tuxxy
approved these changes
Mar 10, 2021
| @@ -17,7 +48,7 @@ pub struct CapsuleFragProof { | |||
| kfrag_pok: CurvePoint, | |||
| signature: CurveScalar, | |||
| kfrag_signature: Signature, | |||
| metadata: CurveScalar, | |||
| metadata: HashedMetadata, | |||
| type HashedMetadataSize = BytesDigestOutputSize; | ||
|
|
||
| #[derive(Clone, Copy, Debug, PartialEq)] | ||
| pub(crate) struct HashedMetadata(GenericArray<u8, HashedMetadataSize>); |
| ) -> CurveScalar { | ||
| ScalarDigest::new_with_dst(b"POLYNOMIAL_ARG") | ||
| .chain_point(precursor) | ||
| .chain_point(pubkey) | ||
| .chain_point(dh_point) | ||
| .chain_scalar(id) | ||
| .chain_bytes(kfrag_id) |
| #[derive(Clone, Copy, Debug, PartialEq)] | ||
| pub(crate) struct KeyFragID(GenericArray<u8, KeyFragIDSize>); | ||
|
|
||
| impl KeyFragID { |
There was a problem hiding this comment.
Very nice, lots of room for other cool additions here in the future.
| @@ -59,7 +91,7 @@ impl KeyFragProof { | |||
| #[allow(clippy::too_many_arguments)] | |||
| fn new( | |||
| params: &Parameters, | |||
| kfrag_id: &CurveScalar, | |||
| kfrag_id: &KeyFragID, | |||
| @@ -151,8 +183,7 @@ impl SerializableToArray for KeyFrag { | |||
|
|
|||
| impl KeyFrag { | |||
| fn new(factory: &KeyFragFactory, sign_delegating_key: bool, sign_receiving_key: bool) -> Self { | |||
| // Was: `os.urandom(bn_size)`. But it seems we just want a scalar? | |||
| let kfrag_id = CurveScalar::random_nonzero(); | |||
| let kfrag_id = KeyFragID::random(); | |||
| @@ -221,7 +252,7 @@ impl KeyFrag { | |||
| let correct_commitment = commitment == &u * &key; | |||
|
|
|||
| let mut digest = SignatureDigest::new() | |||
| .chain_scalar(&kfrag_id) | |||
| .chain_bytes(&kfrag_id) | |||
| @@ -200,7 +231,7 @@ impl CapsuleFrag { | |||
|
|
|||
| let h = ScalarDigest::new() | |||
| .chain_points(&[e, e1, e2, v, v1, v2, u, u1, u2]) | |||
| .chain_scalar(&self.proof.metadata) | |||
| .chain_bytes(&self.proof.metadata) | |||
| @@ -209,7 +240,7 @@ impl CapsuleFrag { | |||
| let kfrag_id = self.kfrag_id; | |||
|
|
|||
| let valid_kfrag_signature = SignatureDigest::new() | |||
| .chain_scalar(&kfrag_id) | |||
| .chain_bytes(&kfrag_id) | |||
| @@ -137,7 +168,7 @@ impl SerializableToArray for CapsuleFrag { | |||
| fn from_array(arr: &GenericArray<u8, Self::Size>) -> Option<Self> { | |||
| let (point_e1, rest) = CurvePoint::take(*arr)?; | |||
| let (point_v1, rest) = CurvePoint::take(rest)?; | |||
| let (kfrag_id, rest) = CurveScalar::take(rest)?; | |||
| let (kfrag_id, rest) = KeyFragID::take(rest)?; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #27
Fixes #21
KeyFragidentifier matches the one used inPyUmbral.CapsuleFragmetadata in bytes instead of a scalar