Hash functions cleanup #36

fjarri · 2021-03-03T05:36:09Z

Time to stop with direct pushing to upstream and start proper procedures.

remove the use of all extraneous hashing (fixes Possibly reduce the amount of hash functions used in the code #2), leaving only SHA256
in particular, halve the range of unsafe_hash_to_point(), since SHA256 gives us 32 bytes and we need 33 to fully define a point.

Not implementing the standardized hash-to-point in this PR, see #35

umbral-pre/src/curve.rs

umbral-pre/src/hashing.rs

umbral-pre/Cargo.toml

umbral-pre/src/params.rs

fjarri requested review from cygnusv and tuxxy March 3, 2021 05:36

fjarri force-pushed the hash-removal branch 2 times, most recently from d019da1 to 44569f0 Compare March 3, 2021 06:14

tuxxy reviewed Mar 3, 2021

View reviewed changes

umbral-pre/src/curve.rs Show resolved Hide resolved

umbral-pre/src/hashing.rs Show resolved Hide resolved

cygnusv reviewed Mar 3, 2021

View reviewed changes

umbral-pre/Cargo.toml Show resolved Hide resolved

umbral-pre/src/params.rs Outdated Show resolved Hide resolved

fjarri requested a review from vepkenez March 3, 2021 20:17

fjarri added 3 commits March 5, 2021 20:50

Replace SHA3 with SHA2-256

8ead19b

Get rid of Blake2 and simplify unsafe_hash_to_point()

6ebdcd1

Add TODOs about non-zero scalar generation

966e08f

fjarri force-pushed the hash-removal branch from 44569f0 to 966e08f Compare March 6, 2021 05:37

fjarri merged commit 125a2c6 into nucypher:master Mar 6, 2021

fjarri deleted the hash-removal branch March 6, 2021 05:47

Provide feedback