Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO-MERGE] Unified Capsule instead of ReconstructedCapsule #24

Closed
wants to merge 14 commits into from
Closed

[NO-MERGE] Unified Capsule instead of ReconstructedCapsule #24

wants to merge 14 commits into from

Commits on Jan 18, 2018

  1. Test for single capsule, not ReconstructedCapsule.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    cf7af6b View commit details
    Browse the repository at this point in the history

  2. Comparing newly reconstructed Capsule (which is just a Capsule) to or… 

    …iginal.
    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    8ca56e7 View commit details
    Browse the repository at this point in the history

  3. We can get a Capsule from either original or reconstructed bytes.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    86bfdb9 View commit details
    Browse the repository at this point in the history

  4. Point.from_bytes is now a classmethod.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    cc5d5fd View commit details
    Browse the repository at this point in the history

  5. We're not using default_backend at the moment.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    54e7d60 View commit details
    Browse the repository at this point in the history

  6. Some PEP8 cleanup.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    f211701 View commit details
    Browse the repository at this point in the history

  7. New Capsule.__init__ allows instantiation from either component set.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    33b16ea View commit details
    Browse the repository at this point in the history

  8. Methods from instantiating from bytes of either original or reconstru… 

    …cted; introducing concept of "contents."
    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    8d71991 View commit details
    Browse the repository at this point in the history

  9. Making byte attributes private.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    f8325eb View commit details
    Browse the repository at this point in the history

  10. More fine-tuning of names.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    3be183d View commit details
    Browse the repository at this point in the history

  11. Using method to get points.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    b2a734d View commit details
    Browse the repository at this point in the history

  12. We don't know for sure that we'll have the original data to check - m… 

    …aybe kick this out to a separate method?
    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    2dd56a8 View commit details
    Browse the repository at this point in the history

  13. Method to get components for comparison.

    @jMyles
    jMyles committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    d0af8c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2018

  1. Walking back the methods for Point addition.

    @jMyles
    jMyles committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    681baa6 View commit details
    Browse the repository at this point in the history