Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking release nucypher-core@0.11.0 #73

Merged
merged 17 commits into from
Aug 1, 2023
Merged

Tracking release nucypher-core@0.11.0 #73

merged 17 commits into from
Aug 1, 2023

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Jul 11, 2023

Type of PR:

  • Other

Required reviews:

  • 1

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #73 (8b1ed8c) into main (e636c6f) will increase coverage by 0.12%.
The diff coverage is 87.09%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   21.09%   21.22%   +0.12%     
==========================================
  Files          17       16       -1     
  Lines        3195     3176      -19     
==========================================
  Hits          674      674              
+ Misses       2521     2502      -19     
Files Changed Coverage Δ
nucypher-core-python/src/lib.rs 0.00% <0.00%> (-0.11%) ⬇️
nucypher-core-wasm/src/lib.rs 0.00% <0.00%> (-0.13%) ⬇️
nucypher-core/src/dkg.rs 89.65% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

@piotr-roslaniec piotr-roslaniec marked this pull request as ready for review July 13, 2023 13:03
CHANGELOG.md Outdated

## 0.10.0 - 2023-06-23
### Added
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put the "Added" (features) section below the "Changed" (incompatible) section -

For every version, list the "Changed" items first (meaning backward incompatible changes), then "Added" (new features), then "Fixed" (bug fixes, or other improvements that do not change the API/ABI).

@@ -0,0 +1 @@
nucypher_core.umbral.Parameters.__init__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon my ignorance, what's this for?

Copy link
Contributor Author

@piotr-roslaniec piotr-roslaniec Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using mypy.stubtest to make sure *.pyi files match runtime of bindings generated by pyo3. This is allowlist for some edge cases we weren't able to get around.

Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@piotr-roslaniec piotr-roslaniec merged commit d1a9cad into main Aug 1, 2023
10 checks passed
@piotr-roslaniec piotr-roslaniec deleted the development branch August 1, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants