Add equals method to protocol objects in WASM bindings #64
Conversation
piotr-roslaniec
force-pushed
the
wasm-equality#56
branch
from
ef84faf
to
23fca8e
Compare
| macro_rules! generate_from_bytes { | ||
| ($struct_name:ident) => { | ||
| #[wasm_bindgen] | ||
| impl $struct_name { | ||
| #[wasm_bindgen(js_name = "fromBytes")] | ||
| pub fn from_bytes(bytes: &[u8]) -> Result<$struct_name, Error> { | ||
| from_bytes(bytes).map(Self) | ||
| } | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Looking good! It's not too abstract and is nice encapsulation of boilerplate for bindings.
| generate_equals!(MessageKit); | ||
| generate_from_bytes!(MessageKit); | ||
| generate_to_bytes!(MessageKit); |
There was a problem hiding this comment.
This is great - can is be abstracted farther or does that cross some kind of line? 😆
There was a problem hiding this comment.
We could put these into generate_common_methods! but I didn't find it as useful.
|
|
||
| #[wasm_bindgen(js_name = toBytes)] | ||
| pub fn to_bytes(&self) -> Box<[u8]> { | ||
| to_bytes(self) |
There was a problem hiding this comment.
the original to_bytes() here uses self. The macro uses &self. Why the discrepancy?
There was a problem hiding this comment.
That's a typo. I think normally clippy would have caught this, but &self was inside the macro. This isn't an issue since the resulting &&self would be coerced to just &self, but it's worth fixing.
| }; | ||
| } | ||
|
|
||
| macro_rules! generate_to_string { |
There was a problem hiding this comment.
🎸 - nice split of the macros.
piotr-roslaniec
force-pushed
the
wasm-equality#56
branch
from
23fca8e
to
0917370
Compare
Type of PR:
Required reviews:
What this does:
equalsmethod to WASM bindingsIssues fixed/closed:
PartialEqandEqfor WASM structs in bindings #56Why it's needed:
Notes for reviewers:
ferveoversiongenerate_to_bytesmay only replace someto_bytesmethods and so will require more work / another macro to be introduced.nucypher