Umbral -> Curve25519 for ThresholdDecryptionRequest/Response #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 15.25% 19.50% +4.25%
==========================================
Files 16 17 +1
Lines 2845 3214 +369
==========================================
+ Hits 434 627 +193
- Misses 2411 2587 +176
|
derekpierre
changed the title
derekpierre
changed the title
derekpierre
requested review from
fjarri,
KPrasch,
cygnusv,
theref and
piotr-roslaniec
Comment on lines
+602
to
+606
| #[allow(clippy::inherent_to_string)] | ||
| #[wasm_bindgen(js_name = toString)] | ||
| pub fn to_string(&self) -> String { | ||
| format!("{}", self.0) | ||
| } |
There was a problem hiding this comment.
Why do we implement to_string here? Is it to display or to serialize these structs? If the former, maybe we could consider using #[wasm_bindgen(inspectable)]
There was a problem hiding this comment.
Following examples from the equivalent objects in Umbral. That being said the to_string for secret keys are rudimentary (constant string).
There was a problem hiding this comment.
I wasn't aware that it existed. But there is a slight difference here I think - toString() now returns the Display impl (that is, it is analogous to str() in Python), but inspectable would return something analogous to repr() in Python or Debug in Rust. Depends on what exactly you want from this method, I guess.
piotr-roslaniec
approved these changes
Jun 1, 2023
fjarri
reviewed
Jun 2, 2023
fjarri
reviewed
Jun 2, 2023
derekpierre
added a commit
to derekpierre/nucypher-core
that referenced
this pull request
Jun 3, 2023
derekpierre
added a commit
to derekpierre/nucypher-core
that referenced
this pull request
Jun 3, 2023
KPrasch
reviewed
Jun 6, 2023
jMyles
reviewed
Jun 6, 2023
cygnusv
reviewed
Jun 6, 2023
…est/response encryption. E2EThresholdDecryptionRequest object is no longer needed as an intermediary since a shared secret key is created/used.
…tSecretKey, RequestPublicKey, RequestSharedSecret. Updated/fixed python and wasm bindings accordingly. Added tests.
…ldDecryptionResponse and EncryptedThresholdDecryptionResponse. Code cleanup.
Change `diffie_hellman()` to `derive_shared_secret()`. Remove unnecessary `make_secret()` from RequestSecretFactory. General code cleanup.
KPrasch
reviewed
Jun 6, 2023
|
needs rebase |
…ble change. Improve error name for invalid seed length.
theref
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to nucypher/nucypher#3129.