-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with ferveo
crate
#53
Conversation
Is it possible to make submodules somehow? Is it a thing in JS? |
Yes, you can implement modules in JS. For example, you can group your exports like this:
I'm not sure how to do it in |
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 15.24% 15.25% +0.01%
==========================================
Files 16 16
Lines 2841 2845 +4
==========================================
+ Hits 433 434 +1
- Misses 2408 2411 +3
|
2e88a1c
to
6a4da8f
Compare
6a4da8f
to
66d7984
Compare
Ok, I just realized this is a known issue: Should be fixed by updating |
e8e355e
to
ba534c6
Compare
ba534c6
to
8c296b8
Compare
950953f
to
0f40ac5
Compare
0f40ac5
to
7770623
Compare
Hi @derekpierre, just wanted to check in with you. Are there any other TODOs that should be covered here? |
Perhaps this one as well? https://github.com/piotr-roslaniec/nucypher-core/blob/ferveo-types/nucypher-core/src/lib.rs#L51. Also adding @KPrasch as a reviewer. -- Do these changes need an related update on the |
@@ -647,7 +649,7 @@ impl ThresholdDecryptionRequest { | |||
pub fn new( | |||
ritual_id: u16, | |||
variant: u8, | |||
ciphertext: &[u8], // TODO use ferveo Ciphertext type | |||
ciphertext: &Ciphertext, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is supremely satisfying to see!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
ferveo
are tracked here: Implement feedback fromnucypher-core
integration ferveo#119PublicKey
toUmbralPublicKey
andFerveoPublicKey
respectively? Technically, it's sufficient to rename one of them,FerveoPublicKey
.FerveoPublicKey