Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce threshold decryption request/response and node metadata ferveo public key #48

Merged
merged 13 commits into from
May 2, 2023
Merged

Introduce threshold decryption request/response and node metadata ferveo public key #48

merged 13 commits into from
May 2, 2023

Conversation

KPrasch
Copy link
Member

@KPrasch KPrasch commented Apr 14, 2023 •
edited
Loading

Description

Introduces new fields supporting the integration of nucypher/nucypher with the ferveo/tpke cryptosystem and DKG protocol.
closes #47 but needs additional follow-up to address #49.

New entities
  • ThresholdDecryptionRequest
  • ThresholdDecryptionResponse
Changes
  • adds a ferveo_public_key field to NodeMetadataPayload
  • bumps NodeMetadataPayload major version from 3 -> 4
  • python bindings for ThresholdDecryptionRequest and ThresholdDecryptionResponse
  • wasm bindings for ThresholdDecryptionRequest and ThresholdDecryptionResponse
  • bumps MSRV for rustc on CI

@KPrasch KPrasch mentioned this pull request Apr 17, 2023
Merged
@derekpierre derekpierre mentioned this pull request Apr 20, 2023
Closed
@KPrasch KPrasch mentioned this pull request Apr 22, 2023
Closed
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023 •
edited
Loading

Codecov Report

Merging #48 (25a9c80) into main (1933a0c) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main     #48      +/-   ##
========================================
- Coverage   7.59%   7.01%   -0.59%     
========================================
  Files         15      16       +1     
  Lines       2329    2523     +194     
========================================
  Hits         177     177              
- Misses      2152    2346     +194
Impacted Files Coverage Δ
nucypher-core-python/src/lib.rs 0.11% <0.00%> (-0.02%) ⬇️
nucypher-core-wasm/src/lib.rs 0.13% <0.00%> (-0.02%) ⬇️
nucypher-core/src/dkg.rs 0.00% <0.00%> (ø)
nucypher-core/src/lib.rs 100.00% <ø> (ø)
nucypher-core/src/node_metadata.rs 0.00% <0.00%> (ø)

@KPrasch KPrasch changed the title [WIP] ThresholdDecryptionRequest and ThresholdDecryptionResponse Introduce threshold decryption request/response and node metadata ferveo public key Apr 22, 2023
@KPrasch KPrasch marked this pull request as ready for review April 22, 2023 22:22
@KPrasch KPrasch requested a review from theref April 30, 2023 22:43
fjarri
fjarri reviewed Apr 30, 2023
View reviewed changes
nucypher-core/src/dkg.rs Outdated Show resolved Hide resolved
@fjarri
Copy link
Contributor

fjarri commented Apr 30, 2023

Remember to update the changelog too

KPrasch added a commit to KPrasch/nucypher-core that referenced this pull request Apr 30, 2023
@KPrasch
respond to RFCs in PR nucypher#48
4e9d1c2
KPrasch added a commit to KPrasch/nucypher-core that referenced this pull request Apr 30, 2023
@KPrasch
respond to RFCs in PR nucypher#48
784a8dc
KPrasch
KPrasch commented Apr 30, 2023
View reviewed changes
nucypher-core/src/dkg.rs Outdated Show resolved Hide resolved
@KPrasch
Copy link
Member Author

KPrasch commented May 1, 2023

✔️ changelog updated

@KPrasch KPrasch added enhancement New feature or request API Related to public API ABI Changes the format of serialized objects labels May 1, 2023
@KPrasch KPrasch requested review from jMyles and derekpierre May 1, 2023 17:07
derekpierre
derekpierre approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 LGTM - though I'm no rust expert 😅

@fjarri fjarri merged commit e9ee8d5 into nucypher:main May 2, 2023
@derekpierre derekpierre mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjarri fjarri fjarri approved these changes

@derekpierre derekpierre derekpierre approved these changes

@theref theref Awaiting requested review from theref

@piotr-roslaniec piotr-roslaniec Awaiting requested review from piotr-roslaniec

@jMyles jMyles Awaiting requested review from jMyles

Assignees
No one assigned
Labels
ABI Changes the format of serialized objects API Related to public API enhancement New feature or request
Projects
v7.0.0 (TACo)
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ThresholdDecryptionRequest and ThresholdDecryptionResponse
5 participants
@KPrasch @codecov-commenter @fjarri @derekpierre @piotr-roslaniec