Take an iterable of capsule and vcfrag in ReencryptionResponse constructor
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage ? 16.09%
=======================================
Files ? 12
Lines ? 466
Branches ? 0
=======================================
Hits ? 75
Misses ? 391
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…r uniformity Both with the other nucypher-core methods, and with Umbral as well
jMyles
reviewed
Oct 5, 2022
| umbral_pre::VerifiedCapsuleFrag::from(vcfrag), | ||
| ) | ||
| }) | ||
| .unzip(); |
There was a problem hiding this comment.
This is a lot for one line, cognitively speaking... so, we're basically mapping the objects to different types, and the unzipping the two sides of the iterable into two new locals, capsules_backend and vcfrags_backend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Capsule, VerifiedCapsuleFrag)tuplesReencryptionResponse::new()(and change bindings correspondingly)IterablewithSequencein Python bindgins: PyO3 cannot take generators as parameters.AuthorizedKeyFrag.verify(),ReencryptionResponse.verify(), andAuthorizedTreasureMap.verify()now consumeself, to match Umbral and the othernucypher-core'sverify()methods.