Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api cleanup #14

Merged
merged 12 commits into from
Mar 14, 2022
Merged

Api cleanup #14

merged 12 commits into from
Mar 14, 2022

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Mar 13, 2022

  • added a HRAC::SIZE constant and moved ADDRESS_SIZE to Address::SIZE
  • added HRAC.from_bytes() in Python bindings to match WASM bindings
  • renamed RevocationOrder::verify_signature() into verify() and made it return a Result<(Address, EncryptedKeyFrag)>. Correspondingly, made RevocationOrder.staking_provider_address private.
  • made MetadataResponse::verify() and ReencryptionResponse::verify() return a Result instead of Option
  • added VerificationError for the use of verification methods above

@fjarri fjarri added API Related to public API Python Related to Python bindings WASM Related to WASM bindings labels Mar 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #14 (4d075ad) into master (cb15d48) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #14   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          12      12           
  Lines         428     434    +6     
======================================
- Misses        428     434    +6     
Impacted Files Coverage Δ
nucypher-core/src/address.rs 0.00% <0.00%> (ø)
nucypher-core/src/hrac.rs 0.00% <0.00%> (ø)
nucypher-core/src/key_frag.rs 0.00% <0.00%> (ø)
nucypher-core/src/node_metadata.rs 0.00% <0.00%> (ø)
nucypher-core/src/reencryption.rs 0.00% <0.00%> (ø)
nucypher-core/src/revocation_order.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb15d48...4d075ad. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to public API Python Related to Python bindings WASM Related to WASM bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants