Skip to content

Conversation

@fjarri
Copy link
Collaborator

@fjarri fjarri commented Nov 4, 2025

Type of PR:

  • Other

Required reviews:

  • 2

What this does:

  • Update the resolver and fix clippy warnings
  • Use serde-encoded-bytes crate instead of `umbral_pre::serde_bytes`` module
  • Use secrecy crate instead of secret_box module
  • Bump wasm-bindgen-derive to 0.3

Fixes #120

Can't bump pyo3 until nucypher/ferveo#218 and nucypher/rust-umbral#135 are in.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.85%. Comparing base (e080d33) to head (ac55cb3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   30.05%   29.85%   -0.21%     
==========================================
  Files          18       17       -1     
  Lines        2349     2338      -11     
==========================================
- Hits          706      698       -8     
+ Misses       1643     1640       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use serde-encoded-bytes and secrecy::SecretBox instead of umbral_pre::serde_bytes and nucypher_core::secret_box

2 participants