Repository navigation
build: pin every source-built tool and the Rust toolchain - #35
Merged
Merged
Conversation
jpegli, flip and butteraugli tracked moving branches, and the Rust tools installed whatever was newest at build time, so two builds could differ despite ADR 0002 stating that versions are pinned. Pin those three to the commits the current image uses (they publish no release tags), and fix the Rust toolchain, dssim and oxipng versions with --locked. Document in ADR 0002 that apt packages still follow Debian point releases.
Codec comparison ✅ no size regression📥 Download the codec report (unzip and open Size check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR 0002 says tool versions are pinned, and the regression gate relies on that, but four inputs floated:
main031a0077f579mainb475eb4bf394(v1.7)master71b18b636b9c1.99.03.5.1/10.2.1,--lockedgit clone --branchcannot take a commit, hencegit init+fetch+checkout.--lockedbuilds each crate with its ownCargo.lock, pinning transitive dependencies too.aptpackages still follow Debian point releases (security fixes), with the size gate catching an output change.Test plan
docker buildsucceeds; the log shows rustc 1.99.0, dssim 3.5.1, oxipng 10.2.1smoke-test.shin the image: 42 ok, 0 failed (butteraugli builds and runs)