Skip to content

Avoid redundant labelset protobuf copy - #3841

Merged
jotare merged 1 commit into
mainfrom
avoid-redundant-copy
Jul 30, 2026
Merged

Avoid redundant labelset protobuf copy#3841
jotare merged 1 commit into
mainfrom
avoid-redundant-copy

Conversation

@jotare

@jotare jotare commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

We can ParseFromString directly without an intermediate copy

How was this PR tested?

Existing test suite

@jotare
jotare requested review from a team as code owners July 30, 2026 10:35
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.48%. Comparing base (267d243) to head (b35a960).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
- Coverage   85.50%   85.48%   -0.03%     
==========================================
  Files         573      573              
  Lines       50913    50911       -2     
  Branches    15695    15695              
==========================================
- Hits        43532    43520      -12     
- Misses       6743     6754      +11     
+ Partials      638      637       -1     
Flag Coverage Δ
nidx 81.29% <ø> (+<0.01%) ⬆️
nucliadb 74.48% <100.00%> (-0.07%) ⬇️
nucliadb-ingest 43.86% <0.00%> (+<0.01%) ⬆️
nucliadb-reader 43.85% <0.00%> (+<0.01%) ⬆️
nucliadb-search 54.82% <0.00%> (+<0.01%) ⬆️
nucliadb-standalone 46.18% <100.00%> (-0.03%) ⬇️
nucliadb-train 44.82% <100.00%> (-0.01%) ⬇️
nucliadb-writer 47.36% <100.00%> (+0.03%) ⬆️
nucliadb_dataset 73.42% <ø> (ø)
nucliadb_models 69.72% <ø> (ø)
nucliadb_sdk 82.30% <ø> (ø)
nucliadb_telemetry 85.67% <ø> (ø)
nucliadb_utils 80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jotare
jotare merged commit 4c70657 into main Jul 30, 2026
41 checks passed
@jotare
jotare deleted the avoid-redundant-copy branch July 30, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants