Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to exlude text from field streaming #2810

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

lferran
Copy link
Contributor

@lferran lferran commented Jan 24, 2025

Description

This makes DA cleanup tasks much more efficient as they don't need the field text itself

How was this PR tested?

Integration tests

@lferran lferran requested a review from a team January 24, 2025 12:56
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (cdb64ad) to head (66ce104).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2810   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files         389      389           
  Lines       24543    24545    +2     
=======================================
+ Hits        21412    21414    +2     
  Misses       3131     3131           
Flag Coverage Δ
nucliadb 74.95% <0.00%> (-0.01%) ⬇️
nucliadb-ingest 40.67% <0.00%> (-0.01%) ⬇️
nucliadb-reader 43.08% <0.00%> (-0.03%) ⬇️
nucliadb-search 44.28% <0.00%> (-0.01%) ⬇️
nucliadb-standalone 47.85% <0.00%> (-0.01%) ⬇️
nucliadb-train 45.92% <100.00%> (+<0.01%) ⬆️
nucliadb-writer 46.39% <0.00%> (-0.01%) ⬇️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 85.73% <ø> (ø)
nucliadb_sdk 80.23% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (ø)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lferran lferran merged commit 135dcfa into main Jan 24, 2025
56 checks passed
@lferran lferran deleted the cleanup-field-stream branch January 24, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants